flare shipping #1352
flare shipping #1352
Conversation
James-Pickett
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -250,46 +251,53 @@ func RunDoctor(ctx context.Context, k types.Knapsack, w io.Writer) { | |||
| } | |||
| } | |||
|
|
|||
| type runtimeEnvironmentTyp string | |||
| type RuntimeEnvironmentType string | |||
There was a problem hiding this comment.
Does this need to be exported?
There was a problem hiding this comment.
yes, this is how the consumer and cmd line paths define standalone / insitu
There was a problem hiding this comment.
They shouldn't need the type exported, just the values for it. (Unless it's in a method signature)
pkg/debug/shipper/shipper.go
Outdated
| currentUser := "unknown" | ||
| consoleUsers, err := consoleuser.CurrentUsers(ctx) | ||
|
|
||
| switch { | ||
| case err != nil: | ||
| currentUser = fmt.Sprintf("error getting current users: %s", err) | ||
| case len(consoleUsers) > 0: | ||
| currentUser = consoleUsers[0].Username | ||
| default: // no console users | ||
| currentUser = "no console users" | ||
| } |
There was a problem hiding this comment.
If it's run from the command line, it should be in the ENV as USER or SUDO_USER, and if it's insitu, we probably want every consuleUser. not just the first.
There was a problem hiding this comment.
I don't quite understand what this means, we should look in the env or set in the env? Also, what should we do with the ENV?
I updated it to include all console users.
There was a problem hiding this comment.
The variable was called currentUser, but it was grabbing the first console user. The console users are valuable, but I'm not sure they're the user taking this action. Consider someone remotely ssh'ed into a machine...
AFAIK the only way to tell the user who is taking the action is to either look at something like your process uid, or if it's from a shell examine os.GetEnv("USER"). sudo will also set os.Getenv("SUDO_USER").
I'm not sure what windows does.
this PR adds 2 options for flare shipping
sudo /usr/local/kolide-2/bin/launcher flare note=some_note save=uploadhere is also a PR @directionless is working to support the gcp uploads