Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed information on KEP process #815

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

anishasthana
Copy link
Contributor

@juliusvonkohout
Copy link
Member

@franciscojavierarceo what do you think?

@franciscojavierarceo
Copy link
Contributor

franciscojavierarceo commented Feb 12, 2025

@franciscojavierarceo what do you think?

My view is that KEPs should be expected from Red Hatter's making medium to large changes. For the rest of the community, we should only encourage it. For large changes we should require it but medium changes may not warrant the overhead.

I don't expect contributors to go through the extensive writing, consensus generating, and community building that Red Hat does when most non-Red Hattters are doing this work in their leisure time.

I made some suggestions to soften the language.

All of that said though, I do think writing in general is a highly useful skill and people (of course, including myself) learn a lot from it!

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this
cc for review
@kubeflow/wg-pipeline-leads @kubeflow/wg-training-leads @kubeflow/wg-data-leads @kubeflow/wg-automl-leads @akgraner @chasecadet @kubeflow/kubeflow-steering-committee @franciscojavierarceo @kubeflow/wg-manifests-leads @kubeflow/wg-training-leads @varodrig @kubeflow/wg-notebooks-leads @rimolive @hbelmiro

proposals/README.md Outdated Show resolved Hide resolved
proposals/README.md Outdated Show resolved Hide resolved
proposals/README.md Outdated Show resolved Hide resolved

### Git and GitHub Implementation

KEPs are checked into the component repo under the `proposals` directory. Note that there isn't yet a standard for where this directory is located.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say that KEPs that affect multiple Kubeflow project should be created under kubeflow/community.
WDYT ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not work that well with kubeflow/manifests rootless efforts, so i would not make it a hard requirement. It can make sense in some areas, but for example helm charts, rootless, istio-cni/ambient are better located in kubeflow/manifests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@andreyvelich andreyvelich Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusvonkohout @kubeflow/wg-manifests-leads can we identify list of improvements that should be discussed under kubeflow/manifests ?
I think, if some of these features belong to manifests, we should update the @kubeflow/wg-manifests-leads charter to include it in their scope: https://github.com/kubeflow/community/blob/master/wg-manifests/charter.md#code-binaries-and-services

For example, WG Manifest is responsible to provide set of security best practices across all Kubeflow projects.
They should work with WG Leads to address them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i think the security topic. So authentication, authorization, Istio, PodSecuritystandards, Securitycontexts, multi-tenancy, RBAC, networkpolicies etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusvonkohout Please can you work towards updating the charter of WG Manifests to include it?
Maybe we can cross-link it from this process, so users better understand to whom they should reach out if they want to contribute new feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the following blurb:

KEPs affecting multiple Kubeflow projects that do not fit into existing cross-component projects such as kubeflow/manifests should be created under kubeflow/community

proposals/README.md Show resolved Hide resolved
proposals/README.md Outdated Show resolved Hide resolved
proposals/README.md Outdated Show resolved Hide resolved
proposals/README.md Show resolved Hide resolved
@anishasthana anishasthana force-pushed the add_proposal_readme branch 3 times, most recently from e3f4be8 to a4135da Compare February 14, 2025 15:00
@varodrig
Copy link
Contributor

/lgtm

@varodrig
Copy link
Contributor

thanks @anishasthana for this.

proposals/README.md Outdated Show resolved Hide resolved
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@andreyvelich
Copy link
Member

Thank you for this great effort @anishasthana!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 34074c1 into kubeflow:master Feb 14, 2025
2 checks passed
@anishasthana anishasthana deleted the add_proposal_readme branch February 14, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants