Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed information on KEP process #815
Add detailed information on KEP process #815
Changes from all commits
37888a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's say that KEPs that affect multiple Kubeflow project should be created under
kubeflow/community
.WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does not work that well with kubeflow/manifests rootless efforts, so i would not make it a hard requirement. It can make sense in some areas, but for example helm charts, rootless, istio-cni/ambient are better located in kubeflow/manifests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also https://github.com/kubeflow/manifests/tree/master/proposals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliusvonkohout @kubeflow/wg-manifests-leads can we identify list of improvements that should be discussed under kubeflow/manifests ?
I think, if some of these features belong to manifests, we should update the @kubeflow/wg-manifests-leads charter to include it in their scope: https://github.com/kubeflow/community/blob/master/wg-manifests/charter.md#code-binaries-and-services
For example, WG Manifest is responsible to provide set of security best practices across all Kubeflow projects.
They should work with WG Leads to address them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i think the security topic. So authentication, authorization, Istio, PodSecuritystandards, Securitycontexts, multi-tenancy, RBAC, networkpolicies etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliusvonkohout Please can you work towards updating the charter of WG Manifests to include it?
Maybe we can cross-link it from this process, so users better understand to whom they should reach out if they want to contribute new feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the following blurb:
KEPs affecting multiple Kubeflow projects that do not fit into existing cross-component projects such as
kubeflow/manifests
should be created underkubeflow/community
This file was deleted.