✨ return set of issues when EKS Node Group is in degraded state #4811
Conversation
k8s-ci-robot
added
the
release-note
|
|
k8s-ci-robot
added
cncf-cla: no
|
Welcome @stefanSpectro! |
k8s-ci-robot
added
needs-ok-to-test
|
Hi @stefanSpectro. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
cncf-cla: yes
stefanSpectro
changed the title
|
/test pull-cluster-api-provider-aws-e2e-eks |
Ankitasw
added
ok-to-test
| errMsgStr = fmt.Sprintf("%s %s", errMsgStr, errMsg) | ||
| } | ||
| reason := capierrors.InvalidConfigurationMachineError | ||
| // TODO: implement checks for other MachineStatusErrors and set reason accordingly |
There was a problem hiding this comment.
Are you planning to add this TODO as part of this PR?
There was a problem hiding this comment.
Hi @Ankitasw I was going to leave this TODO as this PR is implementing returning of the error set.
|
@stefanSpectro would you be able to continue this PR? |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@stefanSpectro: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
stefanSpectro
force-pushed
the
return-set-of-issues-when-ng-in-degraded-state
branch
from
2dda998 to
8307d07
Compare
stefanSpectro
force-pushed
the
return-set-of-issues-when-ng-in-degraded-state
branch
from
ebbcfa7 to
a249c0f
Compare
k8s-ci-robot
added
size/XXL
stefanSpectro
force-pushed
the
return-set-of-issues-when-ng-in-degraded-state
branch
from
7d706e0 to
e3ca115
Compare
stefanSpectro
changed the title
stefanSpectro
force-pushed
the
return-set-of-issues-when-ng-in-degraded-state
branch
from
e3ca115 to
8aa13f7
Compare
|
@Ankitasw any chance you could please take a look when you have time? Thanks |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@stefanSpectro: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
We need this PR because when node groups go in to a degraded state no relevant information is returned to the user. This PR implements code that returns a set of health issues reported for the given node group so a user can have an understanding of what went wrong.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: