Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release binary archive contains unnecessary dir #5397

Conversation

koba1t
Copy link
Member

@koba1t koba1t commented Oct 19, 2023

I think the current binary release script contains a problem that contains an unnecessary directory name for the archive file.

kob@Yugos-MacBook-Air tmp % curl -ssLO "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.0/kustomize_v5.2.0_linux_amd64.tar.gz"
kob@Yugos-MacBook-Air tmp % curl -ssLO "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.1.0/kustomize_v5.1.0_linux_amd64.tar.gz"
kob@Yugos-MacBook-Air tmp % tar xvf kustomize_v5.2.0_linux_amd64.tar.gz
x output/kustomize
kob@Yugos-MacBook-Air tmp % tar xvf kustomize_v5.1.0_linux_amd64.tar.gz
x kustomize

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2023
@koba1t
Copy link
Member Author

koba1t commented Oct 19, 2023

I think the new commands are successful.

kob@Yugos-MacBook-Air tmp % tar cvfz "kustomize.tar.gz" -C output kustomize
a kustomize
kob@Yugos-MacBook-Air tmp % tar xvf kustomize.tar.gz
x kustomize
kob@Yugos-MacBook-Air tmp % file kustomize
kustomize: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=1Rnz85RfK6QgqoJruz46/tpXGW6dqOO1DbuDFlMBp/wjYTqE1kY-HXBeykZluB/pxOYIAvnTi-Es6C1uMcJ, stripped
kob@Yugos-MacBook-Air tmp % zip -j kustomize.zip output/kustomize
updating: kustomize (deflated 60%)
kob@Yugos-MacBook-Air tmp % unzip kustomize.zip
Archive:  kustomize.zip
  inflating: kustomize

@j-chao j-chao mentioned this pull request Oct 19, 2023
@annasong20
Copy link
Contributor

/lgtm
/hold for @koba1t's explicit merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [koba1t,natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sealneaward
Copy link

This will fix the following issue.

@natasha41575
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@natasha41575 natasha41575 merged commit e71072b into kubernetes-sigs:master Oct 19, 2023
5 checks passed
@koba1t koba1t deleted the fix_release_binary_archive_contains_unnecessary_dir branch October 19, 2023 20:14
@natasha41575
Copy link
Contributor

FYI @koba1t I'm rereleasing kustomize right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants