Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Addon] add volcano addon #13876

Closed
wants to merge 3 commits into from
Closed

[Addon] add volcano addon #13876

wants to merge 3 commits into from

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Mar 29, 2022 •
edited
Loading

Add addon for volcano

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@hwdef
Copy link
Member Author

hwdef commented Mar 29, 2022

Ref: volcano-sh/volcano#2128

@hwdef hwdef changed the title add volcano addons add volcano addon Mar 29, 2022
@hwdef hwdef changed the title add volcano addon [Addon] add volcano addon Mar 29, 2022
@spowelljr
Copy link
Member

Hi @hwdef, thanks for your PR!

It would be important to add integration tests for this addon to ensure that it's working and we can detect if it breaks in the future, thanks!

@hwdef hwdef force-pushed the master branch 2 times, most recently from a433114 to 1745db8 Compare March 31, 2022 02:00
@hwdef
Copy link
Member Author

hwdef commented Mar 31, 2022

@spowelljr
I'm a little confused. I didn't add new functions, I don't know how to add integration tests.
And I checked other addon's PRs and also didn't find how they add tests

@spowelljr
Copy link
Member

You didn't add new functions, but you did add an entirely new addon to the project. For example if apiextensions.k8s.io/v1 gets deprecated (like what recently happened to apiextensions.k8s.io/v1beta1), without tests we won't know the addon has stopped working until someone tells us.

For example, here is how we test the GCP addon:

minikube/test/integration/addons_test.go

Line 600 in 03b5bb7

func validateGCPAuthAddon(ctx context.Context, t *testing.T, profile string) {

@hwdef hwdef force-pushed the master branch 4 times, most recently from 4244163 to f81eeda Compare March 31, 2022 15:45
@hwdef
Copy link
Member Author

hwdef commented Mar 31, 2022 •
edited
Loading

@spowelljr

Thanks for your guidance, I have added the test

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 31, 2022
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@hwdef hwdef force-pushed the master branch 2 times, most recently from 5d0e694 to 45179da Compare April 1, 2022 06:22
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2023
@lowang-bh
Copy link
Member

lowang-bh commented Aug 27, 2023 •
edited
Loading

Is this still need? Can we continue on it?

@hwdef hwdef mentioned this pull request Aug 28, 2023
Closed
@spowelljr spowelljr removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 18, 2023
@spowelljr
Copy link
Member

@lowang-bh It needs a rebase, I tried but I don't have write permission to their repo

@Monokaix
Copy link
Member

@hwdef Are you still working on this?

@hwdef
Copy link
Member Author

hwdef commented Jan 29, 2024

@hwdef Are you still working on this?

I didn't push any further, I couldn't pass all the test bots. But I've tested my code locally with no issues. You can use my code if you want to continue.

@Monokaix
Copy link
Member

retrigger ci @minikube-bot

@spowelljr spowelljr reopened this Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hwdef
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13876) |
+----------------+----------+---------------------+
| minikube start | 49.9s    | 50.2s               |
| enable ingress | 26.8s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube start: 48.1s 49.2s 50.6s 50.7s 50.8s
Times for minikube (PR 13876) start: 51.2s 50.5s 49.7s 49.0s 50.4s

Times for minikube ingress: 27.7s 23.7s 27.1s 28.2s 27.1s
Times for minikube (PR 13876) ingress: 26.7s 27.1s 27.1s 27.2s 24.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13876) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 24.2s               |
| enable ingress | 20.9s    | 21.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 25.4s 22.7s 24.7s 24.8s
Times for minikube (PR 13876) start: 25.1s 25.1s 25.2s 22.7s 22.7s

Times for minikube ingress: 20.8s 20.9s 21.8s 20.8s 20.4s
Times for minikube (PR 13876) ingress: 21.4s 20.9s 18.8s 27.9s 18.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13876) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.7s               |
| enable ingress | 34.4s    | 31.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 23.2s 22.0s 21.4s 23.7s
Times for minikube (PR 13876) start: 21.1s 23.2s 23.6s 21.2s 24.6s

Times for minikube ingress: 31.4s 31.3s 31.4s 46.3s 31.3s
Times for minikube (PR 13876) ingress: 31.3s 31.3s 30.3s 31.4s 31.4s

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2024
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestAddons/parallel/Volcano (gopogh) n/a
Docker_Linux_crio_arm64 TestAddons/parallel/Volcano (gopogh) n/a
Docker_Linux_docker_arm64 TestAddons/parallel/Volcano (gopogh) n/a
Docker_Linux_containerd_arm64 TestAddons/parallel/CSI (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/LocalPath (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Registry (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestAddons/serial/GCPAuth/Namespaces (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/CSI (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/LocalPath (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/serial/GCPAuth/Namespaces (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/CSI (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/LocalPath (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/Registry (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestAddons/serial/GCPAuth/Namespaces (gopogh) 0.00 (chart)
KVM_Linux_crio TestAddons/parallel/MetricsServer (gopogh) 5.13 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Headlamp (gopogh) 5.26 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/Registry (gopogh) 5.26 (chart)
KVM_Linux_crio TestPause/serial/SecondStartNoReconfiguration (gopogh) 35.90 (chart)

To see the flake rates of all tests by environment, click here.

@ComradeProgrammer ComradeProgrammer mentioned this pull request Apr 8, 2024
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2024
@lowang-bh lowang-bh mentioned this pull request May 5, 2024
Closed
@medyagh medyagh closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal left review comments

@spowelljr spowelljr spowelljr requested changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@hwdef @minikube-bot @spowelljr @minikube-pr-bot @medyagh @k8s-triage-robot @k8s-ci-robot @lowang-bh @Monokaix @sharifelgamal