Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support to io.weight setting #494

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

lubinszARM
Copy link
Contributor

What type of PR is this?

Features

What this PR does / why we need it:

This patch provied the feature of io.weight setting.

Which issue(s) this PR fixes:

In production area, some critical services and online pods were affected by busy io.

Special notes for your reviewer:

None.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 53.96825% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 55.05%. Comparing base (b122f7b) to head (f2fbdd1).
Report is 6 commits behind head on main.

❗ Current head f2fbdd1 differs from pull request most recent head b30e983. Consider uploading reports for the commit b30e983 to get more accurate results

Files Patch % Lines
...qrm-plugins/io/handlers/ioweight/ioweight_linux.go 53.60% 42 Missing and 3 partials ⚠️
pkg/agent/qrm-plugins/io/staticpolicy/policy.go 53.33% 6 Missing and 1 partial ⚠️
cmd/katalyst-agent/app/options/qrm/io_plugin.go 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   55.67%   55.05%   -0.63%     
==========================================
  Files         552      513      -39     
  Lines       59419    56761    -2658     
==========================================
- Hits        33083    31250    -1833     
+ Misses      22899    22181     -718     
+ Partials     3437     3330     -107     
Flag Coverage Δ
unittest 55.05% <53.96%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

csfldf
csfldf previously approved these changes Apr 9, 2024
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
Signed-off-by: Jianyu Sun <sjycsfldf@gmail.com>
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
@zzzzhhb zzzzhhb merged commit a0246f3 into kubewharf:main Apr 9, 2024
8 checks passed
waynepeking348 pushed a commit that referenced this pull request Apr 12, 2024
* feat: adding support to qos level io.weight setting

Signed-off-by: Robin Lu <robin.lu@bytedance.com>

* feat: adding support to cgroup level io.weight setting

Signed-off-by: Jianyu Sun <sjycsfldf@gmail.com>
Signed-off-by: Robin Lu <robin.lu@bytedance.com>

---------

Signed-off-by: Robin Lu <robin.lu@bytedance.com>
Signed-off-by: Jianyu Sun <sjycsfldf@gmail.com>
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
* feat: adding support to qos level io.weight setting

Signed-off-by: Robin Lu <robin.lu@bytedance.com>

* feat: adding support to cgroup level io.weight setting

Signed-off-by: Jianyu Sun <sjycsfldf@gmail.com>
Signed-off-by: Robin Lu <robin.lu@bytedance.com>

---------

Signed-off-by: Robin Lu <robin.lu@bytedance.com>
Signed-off-by: Jianyu Sun <sjycsfldf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants