Skip to content

Commit

Permalink
Added fix for marker naming bug and check for drawing gating gmm
Browse files Browse the repository at this point in the history
  • Loading branch information
nchuynh committed Jun 29, 2023
1 parent f9f1423 commit 84d006d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
4 changes: 2 additions & 2 deletions minerva_analysis/client/src/js/views/channelList.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ class ChannelList {

};
// Draws rows in the channel list
_.each(this.columns, column => {
let channelID = column.replace(/[ ,.]/g, '').replace(/\//g, '');
_.each(this.columns, (column, index) => {
let channelID = `channel_${index}`;
this.channelIDs[column] = channelID;
// div for each row in channel list
let listItemParentDiv = document.createElement("div");
Expand Down
12 changes: 7 additions & 5 deletions minerva_analysis/client/src/js/views/csvGatingList.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ class CSVGatingList {
this.selections[fullName] = values;
this.sliders.get(name).value(values);
this.eventHandler.trigger(CSVGatingList.events.GATING_BRUSH_MOVE, this.selections);
this.getAndDrawGatingGMM(name).then(() => {
this.eventHandler.trigger(CSVGatingList.events.GATING_BRUSH_END, this.selections);
});
if (!(name in this.hasGatingGMM)) {
this.getAndDrawGatingGMM(name).then(() => {
this.eventHandler.trigger(CSVGatingList.events.GATING_BRUSH_END, this.selections);
});
}
}

/**
Expand Down Expand Up @@ -93,8 +95,8 @@ class CSVGatingList {
};
// Draws rows in the gating list
this.columns.push('Area'); // Add 'Area' to Gating List
_.each(this.columns, column => {
let channelID = column.replace(/[ ,.]/g, '').replace(/\//g, '');
_.each(this.columns, (column, index) => {
let channelID = `channel_${index}`;
this.gatingIDs[column] = channelID;
// div for each row in gating list
let listItemParentDiv = document.createElement("div");
Expand Down

0 comments on commit 84d006d

Please sign in to comment.