feat(l1): add tx broadcasting time interval flag to cli #4751
+30
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
mpaulucci
reviewed
Oct 6, 2025
| dev: Default::default(), | ||
| force: false, | ||
| mempool_max_size: Default::default(), | ||
| tx_broadcasting_time_interval: Default::default(), |
There was a problem hiding this comment.
isnt this 0? Do we actually want the default?
mpaulucci
reviewed
Oct 6, 2025
cmd/ethrex/cli.rs
Outdated
| pub discovery_port: String, | ||
| #[arg( | ||
| long = "p2p.tx-broadcasting-interval", | ||
| default_value = "1000", |
There was a problem hiding this comment.
Can you put this as a constant instead of hardcoding it here?
mpaulucci
reviewed
Oct 8, 2025
cmd/ethrex/cli.rs
Outdated
| use ethrex_config::networks::Network; | ||
|
|
||
| // Amount of seconds between each broadcast | ||
| const BROADCAST_INTERVAL_MS: u64 = 1000; // 1 second |
There was a problem hiding this comment.
why did you move it here?
There was a problem hiding this comment.
I must have misunderstood, I thought this was what you ment here. How should I put this as a constant then?
There was a problem hiding this comment.
can't you import the constant from the place it was originally?
There was a problem hiding this comment.
Oh! Yes! Done here!
fmoletta
approved these changes
Oct 8, 2025
mpaulucci
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've detected that the Request Blob Pooled Transactions Multiple hive test is failing with:
FAIL: Error executing step 4: expected 1 hashes, got 5and that's because there's a 1 second interval between broadcasting transactions that batch several (in this case 5) transactions before sending them, instead of broadcasting a transaction as soon as it arrives. To pass the test but still be able to batch transactions (since it translates in a significative improvement in performance) I'm introducing a new flag in the cli to set the interval as needed.
Description
This pr introduces a new flag in the cli to control the size of the broadcasting time interval for broadcasting transactions.
This pr depends on this other pr to be merged in lambda/hive to pass the ci.
Closes #3914