Add tx broadcasting time interval flag #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed in favor of ethereum#1352 |
github-merge-queue bot
pushed a commit
to lambdaclass/ethrex
that referenced
this pull request
Oct 14, 2025
**Motivation** We've detected that the Request Blob Pooled Transactions Multiple hive test is failing with: `FAIL: Error executing step 4: expected 1 hashes, got 5` and that's because there's a 1 second interval between broadcasting transactions that batch several (in this case 5) transactions before sending them, instead of broadcasting a transaction as soon as it arrives. To pass the test but still be able to batch transactions (since it translates in a significative improvement in performance) I'm introducing a new flag in the cli to set the interval as needed. **Description** This pr introduces a new flag in the cli to control the size of the broadcasting time interval for broadcasting transactions. This pr depends on this other [pr](lambdaclass/hive#42) to be merged in lambda/hive to pass the ci. Closes #3914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set new broadcasting time interval flag for launching ethrex.
This new flag is related to this pr.