Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work on a migration guide for 3 #122

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jan 14, 2022

Q A
Documentation yes

Description

Provides a starting point for a migration guide to 3.x

@gsteel
Copy link
Member Author

gsteel commented Jan 14, 2022

Depends on #118 for CI to get off the ground

@froschdesign froschdesign self-assigned this Jan 14, 2022
@froschdesign froschdesign added this to the 3.0.0 milestone Jan 14, 2022
@froschdesign froschdesign marked this pull request as draft January 14, 2022 11:58
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a first quick review with some comments. 😃

mkdocs.yml Outdated Show resolved Hide resolved
docs/book/migrating.md Outdated Show resolved Hide resolved
docs/book/migrating.md Outdated Show resolved Hide resolved
docs/book/migrating.md Outdated Show resolved Hide resolved
docs/book/migrating.md Outdated Show resolved Hide resolved
docs/book/migrating.md Outdated Show resolved Hide resolved
@gsteel
Copy link
Member Author

gsteel commented Jan 14, 2022

Thanks for the review @froschdesign 👍

gsteel and others added 11 commits January 25, 2024 11:58
Signed-off-by: George Steel <george@net-glue.co.uk>
Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
…er line

Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Copy link
Member Author

gsteel commented Jan 25, 2024

@froschdesign
As a starting point, is this good enough for now?
I'd like to get it merged into 3.x so that I can deal with other changes in the same patch as the code changes - this will help me keep track of what's going on!

@gsteel gsteel marked this pull request as ready for review January 25, 2024 12:06
@froschdesign
Copy link
Member

@gsteel
Go! We will review the migration guide before the new major release.

@gsteel
Copy link
Member Author

gsteel commented Jan 25, 2024

Thanks @froschdesign 👍

@gsteel gsteel merged commit 18086e8 into laminas:3.0.x Jan 25, 2024
5 checks passed
@gsteel gsteel deleted the migration-guide branch January 25, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants