Feature/835 brightness increase tracking #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudteil
approved these changes
May 23, 2024
JulianHammerl
force-pushed
the
feature/835-brightness-increase-tracking
branch
4 times, most recently
from
87d425e to
f02d21b
Compare
patkenneally
approved these changes
May 24, 2024
src/fswAlgorithms/imageProcessing/centerOfBrightness/centerOfBrightness.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/imageProcessing/centerOfBrightness/centerOfBrightness.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/imageProcessing/centerOfBrightness/centerOfBrightness.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/imageProcessing/centerOfBrightness/centerOfBrightness.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/imageProcessing/centerOfBrightness/_UnitTest/test_centerOfBrightness.py
Show resolved
Hide resolved
JulianHammerl
force-pushed
the
feature/835-brightness-increase-tracking
branch
from
f02d21b to
bfea44f
Compare
JulianHammerl
force-pushed
the
feature/835-brightness-increase-tracking
branch
from
bfea44f to
a987f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The centerOfBrightness module was updated to compute the total normalized brightness and determine the rolling average of the total brightness. This can be used to track the brightness of the asteroid and make sure it is increasing over time.
The reviewers should be aware that this branch is based off the 833-cob-windowing branch which is currently under review and needs to be merged first (commits 1-10).
Verification
The unit test was updated and passes.
Documentation
The documentation was updated accordingly.
Future work
N/A