feat: extend the whitespace linter to proof bodies#30658
Open
grunweg wants to merge 434 commits intoleanprover-community:masterfrom
Open
feat: extend the whitespace linter to proof bodies#30658grunweg wants to merge 434 commits intoleanprover-community:masterfrom
whitespace linter to proof bodies#30658grunweg wants to merge 434 commits intoleanprover-community:masterfrom
Conversation
github-actions
bot
added
the
large-import
PR summary d81f18c578Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Tactic.Linter.Whitespace | 1 | 8 | +7 (+700.00%) |
| Mathlib.Util.Superscript | 50 | 4 | -46 (-92.00%) |
| Mathlib.CategoryTheory.Monoidal.Action.Basic | 308 | 310 | +2 (+0.65%) |
| Mathlib.Data.Num.Bitwise | 376 | 378 | +2 (+0.53%) |
| Mathlib.Data.Vector.MapLemmas | 376 | 378 | +2 (+0.53%) |
| Mathlib.Data.Fin.Fin2 | 398 | 400 | +2 (+0.50%) |
| Mathlib.CategoryTheory.Comma.Over.OverClass | 434 | 436 | +2 (+0.46%) |
| Mathlib.CategoryTheory.Bicategory.Yoneda | 436 | 438 | +2 (+0.46%) |
| Mathlib.Data.Finsupp.Notation | 441 | 443 | +2 (+0.45%) |
| Mathlib.CategoryTheory.Limits.Shapes.BinaryProducts | 443 | 445 | +2 (+0.45%) |
| Mathlib.Data.DFinsupp.Notation | 452 | 454 | +2 (+0.44%) |
| Mathlib.CategoryTheory.Limits.Shapes.ZeroMorphisms | 458 | 460 | +2 (+0.44%) |
| Mathlib.CategoryTheory.Monoidal.Mon_ | 466 | 468 | +2 (+0.43%) |
| Mathlib.Data.Finset.Sort | 481 | 483 | +2 (+0.42%) |
| Mathlib.Data.Sym.Sym2 | 488 | 490 | +2 (+0.41%) |
| Mathlib.Algebra.Category.Ring.Basic | 507 | 509 | +2 (+0.39%) |
| Mathlib.Data.PNat.Xgcd | 524 | 526 | +2 (+0.38%) |
| Mathlib.Computability.Language | 532 | 534 | +2 (+0.38%) |
| Mathlib.Algebra.Module.TransferInstance | 533 | 535 | +2 (+0.38%) |
| Mathlib.Computability.ContextFreeGrammar | 533 | 535 | +2 (+0.38%) |
| Mathlib.Algebra.Order.CauSeq.Basic | 540 | 542 | +2 (+0.37%) |
| Mathlib.Data.Finset.Slice | 558 | 560 | +2 (+0.36%) |
| Mathlib.CategoryTheory.Limits.Shapes.Pullback.IsPullback.Basic | 607 | 609 | +2 (+0.33%) |
| Mathlib.Computability.Partrec | 611 | 613 | +2 (+0.33%) |
| Mathlib.Computability.PartrecCode | 612 | 614 | +2 (+0.33%) |
| Mathlib.CategoryTheory.Monoidal.OfHasFiniteProducts | 647 | 649 | +2 (+0.31%) |
| Mathlib.Algebra.GroupWithZero.Range | 668 | 670 | +2 (+0.30%) |
| Mathlib.Algebra.AffineMonoid.Basic | 674 | 676 | +2 (+0.30%) |
| Mathlib.ModelTheory.Syntax | 695 | 697 | +2 (+0.29%) |
| Mathlib.Algebra.Order.GroupWithZero.Range | 697 | 699 | +2 (+0.29%) |
| Mathlib.Topology.DenseEmbedding | 697 | 699 | +2 (+0.29%) |
| Mathlib.Data.NNReal.Defs | 712 | 714 | +2 (+0.28%) |
| Mathlib.Algebra.Category.Grp.EpiMono | 716 | 718 | +2 (+0.28%) |
| Mathlib.Data.ENNReal.Basic | 716 | 718 | +2 (+0.28%) |
| Mathlib.Data.EReal.Operations | 721 | 723 | +2 (+0.28%) |
| Mathlib.Combinatorics.SetFamily.LYM | 736 | 738 | +2 (+0.27%) |
| Mathlib.CategoryTheory.Monoidal.Cartesian.CommGrp_ | 767 | 769 | +2 (+0.26%) |
| Mathlib.Topology.Category.TopCat.Limits.Basic | 774 | 776 | +2 (+0.26%) |
| Mathlib.Algebra.Homology.SpectralObject.Basic | 789 | 791 | +2 (+0.25%) |
| Mathlib.Algebra.Homology.SpectralObject.HasSpectralSequence | 794 | 796 | +2 (+0.25%) |
| Mathlib.LinearAlgebra.TensorProduct.Defs | 806 | 808 | +2 (+0.25%) |
| Mathlib.Topology.Sheaves.Presheaf | 806 | 808 | +2 (+0.25%) |
| Mathlib.NumberTheory.FactorisationProperties | 811 | 813 | +2 (+0.25%) |
| Mathlib.Algebra.Homology.SpectralObject.Cycles | 840 | 842 | +2 (+0.24%) |
| Mathlib.Algebra.Homology.SpectralObject.Page | 844 | 846 | +2 (+0.24%) |
| Mathlib.Algebra.Homology.SpectralObject.Differentials | 845 | 847 | +2 (+0.24%) |
| Mathlib.Algebra.Homology.SpectralObject.EpiMono | 847 | 849 | +2 (+0.24%) |
| Mathlib.CategoryTheory.Adhesive.Basic | 855 | 857 | +2 (+0.23%) |
| Mathlib.CategoryTheory.Abelian.SerreClass.Localization | 870 | 872 | +2 (+0.23%) |
| Mathlib.ModelTheory.Topology.Types | 892 | 894 | +2 (+0.22%) |
| Mathlib.RingTheory.Localization.Basic | 901 | 903 | +2 (+0.22%) |
| Mathlib.Algebra.Homology.Refinements | 955 | 957 | +2 (+0.21%) |
| Mathlib.LinearAlgebra.TensorPower.Symmetric | 976 | 978 | +2 (+0.20%) |
| Mathlib.CategoryTheory.Functor.ReflectsIso.Exact | 979 | 981 | +2 (+0.20%) |
| Mathlib.Algebra.Algebra.Operations | 994 | 996 | +2 (+0.20%) |
| Mathlib.LinearAlgebra.TensorProduct.Decomposition | 1017 | 1019 | +2 (+0.20%) |
| Mathlib.Topology.Algebra.IsUniformGroup.Defs | 1054 | 1056 | +2 (+0.19%) |
| Mathlib.Topology.Sheaves.LocallySurjective | 1054 | 1056 | +2 (+0.19%) |
| Mathlib.AlgebraicTopology.SimplicialComplex.Basic | 1069 | 1071 | +2 (+0.19%) |
| Mathlib.LinearAlgebra.AffineSpace.Simplex.Centroid | 1073 | 1075 | +2 (+0.19%) |
| Mathlib.RingTheory.Valuation.Basic | 1114 | 1116 | +2 (+0.18%) |
| Mathlib.RingTheory.Nilpotent.Exp | 1137 | 1139 | +2 (+0.18%) |
| Mathlib.Analysis.Convex.SimplicialComplex.AffineIndependentUnion | 1152 | 1154 | +2 (+0.17%) |
| Mathlib.CategoryTheory.Triangulated.TStructure.TruncLTGE | 1169 | 1171 | +2 (+0.17%) |
| Mathlib.CategoryTheory.Triangulated.TStructure.TruncLEGT | 1170 | 1172 | +2 (+0.17%) |
| Mathlib.CategoryTheory.Triangulated.TStructure.ETrunc | 1172 | 1174 | +2 (+0.17%) |
| Mathlib.Topology.Instances.Rat | 1189 | 1191 | +2 (+0.17%) |
| Mathlib.Data.Matrix.Cartan | 1204 | 1206 | +2 (+0.17%) |
| Mathlib.Algebra.Polynomial.RuleOfSigns | 1216 | 1218 | +2 (+0.16%) |
| Mathlib.Analysis.Normed.Ring.WithAbs | 1280 | 1282 | +2 (+0.16%) |
| Mathlib.Algebra.Homology.HomotopyCategory.MappingCocone | 1284 | 1286 | +2 (+0.16%) |
| Mathlib.Algebra.Quaternion | 1293 | 1295 | +2 (+0.15%) |
| Mathlib.RepresentationTheory.Intertwining | 1450 | 1452 | +2 (+0.14%) |
| Mathlib.MeasureTheory.Measure.MutuallySingular | 1490 | 1492 | +2 (+0.13%) |
| Mathlib.Topology.Algebra.Valued.ValuativeRel | 1521 | 1523 | +2 (+0.13%) |
| Mathlib.Topology.Algebra.Valued.ValuedField | 1538 | 1540 | +2 (+0.13%) |
| Mathlib.Topology.Sheaves.Abelian | 1574 | 1576 | +2 (+0.13%) |
| Mathlib.AlgebraicGeometry.EllipticCurve.Jacobian.Basic | 1650 | 1652 | +2 (+0.12%) |
| Mathlib.AlgebraicGeometry.EllipticCurve.Projective.Basic | 1650 | 1652 | +2 (+0.12%) |
| Mathlib.AlgebraicGeometry.EllipticCurve.Projective.Formula | 1652 | 1654 | +2 (+0.12%) |
| Mathlib.Analysis.Normed.Module.PiTensorProduct.ProjectiveSeminorm | 1659 | 1661 | +2 (+0.12%) |
| Mathlib.RepresentationTheory.Action | 1675 | 1677 | +2 (+0.12%) |
| Mathlib.LinearAlgebra.Center | 1684 | 1686 | +2 (+0.12%) |
| Mathlib.NumberTheory.Height.Basic | 1734 | 1736 | +2 (+0.12%) |
| Mathlib.FieldTheory.Finite.Extension | 1743 | 1745 | +2 (+0.11%) |
| Mathlib.AlgebraicTopology.SimplicialSet.CompStructTruncated | 881 | 882 | +1 (+0.11%) |
| Mathlib.FieldTheory.CardinalEmb | 1772 | 1774 | +2 (+0.11%) |
| Mathlib.RingTheory.Valuation.RankOne | 1783 | 1785 | +2 (+0.11%) |
| Mathlib.Analysis.Distribution.ContDiffMapSupportedIn | 1802 | 1804 | +2 (+0.11%) |
| Mathlib.AlgebraicTopology.SimplicialSet.Path | 911 | 912 | +1 (+0.11%) |
| Mathlib.AlgebraicTopology.SimplicialSet.StrictSegal | 912 | 913 | +1 (+0.11%) |
| Mathlib.Analysis.Analytic.Order | 1826 | 1828 | +2 (+0.11%) |
| Mathlib.Analysis.CStarAlgebra.ContinuousFunctionalCalculus.Unital | 1827 | 1829 | +2 (+0.11%) |
| Mathlib.Topology.Algebra.Module.FiniteDimensionBilinear | 1904 | 1906 | +2 (+0.11%) |
| Mathlib.Analysis.Real.Pi.Bounds | 1977 | 1979 | +2 (+0.10%) |
| Mathlib.Topology.Algebra.Valued.WithVal | 1992 | 1994 | +2 (+0.10%) |
| Mathlib.RepresentationTheory.Invariants | 2020 | 2022 | +2 (+0.10%) |
| Mathlib.NumberTheory.Niven | 2025 | 2027 | +2 (+0.10%) |
| Mathlib.Computability.AkraBazzi.AkraBazzi | 2047 | 2049 | +2 (+0.10%) |
| Mathlib.RingTheory.Teichmuller | 2097 | 2099 | +2 (+0.10%) |
| Mathlib.NumberTheory.Padics.WithVal | 2159 | 2161 | +2 (+0.09%) |
| Mathlib.FieldTheory.Laurent | 2207 | 2209 | +2 (+0.09%) |
| Mathlib.FieldTheory.RatFunc.Luroth | 2216 | 2218 | +2 (+0.09%) |
| Mathlib.MeasureTheory.Function.L1Space.Integrable | 2217 | 2219 | +2 (+0.09%) |
| Mathlib.Analysis.Normed.Algebra.Spectrum | 2219 | 2221 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.Notation | 2226 | 2228 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.MFDeriv.NormedSpace | 2236 | 2238 | +2 (+0.09%) |
| Mathlib.RingTheory.LaurentSeries | 2239 | 2241 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.VectorBundle.MDifferentiable | 2245 | 2247 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.VectorBundle.Tensoriality | 2253 | 2255 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.ContMDiffMFDeriv | 2254 | 2256 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.VectorBundle.CovariantDerivative.Basic | 2257 | 2259 | +2 (+0.09%) |
| Mathlib.Analysis.Normed.Field.Krasner | 2259 | 2261 | +2 (+0.09%) |
| Mathlib.Analysis.Normed.Algebra.Basic | 2265 | 2267 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.VectorField.Pullback | 2273 | 2275 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.VectorField.LieBracket | 2274 | 2276 | +2 (+0.09%) |
| Mathlib.NumberTheory.Padics.Complex | 2309 | 2311 | +2 (+0.09%) |
| Mathlib.MeasureTheory.Integral.Bochner.SumMeasure | 2339 | 2341 | +2 (+0.09%) |
| Mathlib.MeasureTheory.Function.ConditionalExpectation.PullOut | 2402 | 2404 | +2 (+0.08%) |
| Mathlib.RingTheory.Valuation.Discrete.RankOne | 2441 | 2443 | +2 (+0.08%) |
| Mathlib.MeasureTheory.Measure.Haar.InnerProductSpace | 2327 | 2328 | +1 (+0.04%) |
| Mathlib.Geometry.Euclidean.Volume.Measure | 2435 | 2436 | +1 (+0.04%) |
| Mathlib.Analysis.InnerProductSpace.Reproducing | 2445 | 2446 | +1 (+0.04%) |
| Mathlib.MeasureTheory.Integral.TorusIntegral | 2544 | 2545 | +1 (+0.04%) |
| Mathlib.NumberTheory.Chebyshev | 2595 | 2596 | +1 (+0.04%) |
| Mathlib.Analysis.Distribution.SchwartzSpace.Basic | 2626 | 2627 | +1 (+0.04%) |
| Mathlib.Analysis.SpecialFunctions.Gamma.Digamma | 2655 | 2656 | +1 (+0.04%) |
| Mathlib.Analysis.Polynomial.MahlerMeasure | 2753 | 2754 | +1 (+0.04%) |
| Mathlib.NumberTheory.ModularForms.EisensteinSeries.E2.Summable | 2989 | 2990 | +1 (+0.03%) |
| Mathlib.NumberTheory.ModularForms.EisensteinSeries.E2.Transform | 2991 | 2992 | +1 (+0.03%) |
| Mathlib.NumberTheory.ModularForms.Delta | 2996 | 2997 | +1 (+0.03%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 7753 files with changed transitive imports taking up over 335541 characters: this is too many to display! | |
You can run ci-tools/scripts/pr_summary/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
+ A'
+ B'
+ C'
+ Correspondence
+ D'
+ DFX
+ ExcludedSyntaxNodeKind
+ ExcludedSyntaxNodeKind.contains
+ FX(_
+ PPref
+ S
+ String.norm
+ _root_.Lean.SourceInfo.getLeadTrail
+ _root_.Lean.SourceInfo.removeSpaces
+ _root_.Lean.Syntax.eraseLeadTrailSpaces
+ _root_.String.Slice.mkGroups
+ atomOrIdentEndPos
+ byTens
+ forceNoSpaceAfter
+ forceSpaceAfter
+ forceSpaceAfter3
+ generateCorrespondence
+ getChoiceNode
+ ignoreSpaceAfter
+ ignoreSpaceAfter3
+ leftInverse_of_surjective_of_rightInverse
+ leftInverse_of_surjective_of_rightInverse1
+ mkExpectedWindow
+ mkRangeError
+ mkWdw
+ mkWindowSubstring'
+ onlineComment
+ ppCategory'
+ pretty
+ readWhile
+ reduceWhitespace
+ totalExclusions
+ unSubscript
+ unSubscript'
+ unSuperscript
+ unSuperscript'
+ unparseable
++ instance {R} : Add R := sorry
- CommandStart.endPos
- FormatError
- bar
- foo
- getUnlintedRanges
- instance : ToString FormatError
- isOutside
- mkFormatError
- parallelScan
- parallelScanAux
- pushFormatError
- unlintedNodes
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (1.00, 0.08)
| Current number | Change | Type |
|---|---|---|
| 12 | 1 | disabled deprecation lints |
Current commit fef903a911
Reference commit d81f18c578
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
grunweg
force-pushed
the
commandStart_more_uptodate
branch
from
b497d6e to
38c3480
Compare
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2025
Extracted from #30658. Found by `adomani`'s extension of the commandStart linter to proof bodies.
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
grunweg
added a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 19, 2025
Extracted from leanprover-community#30658. Found by extending the commandStart linter to proof bodies.
grunweg
pushed a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 19, 2025
Extracted from leanprover-community#30658. Found by extending the commandStart linter to proof bodies.
grunweg
pushed a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 19, 2025
Extracted from leanprover-community#30658. Found by extending the commandStart linter to proof bodies.
grunweg
pushed a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 19, 2025
Extracted from leanprover-community#30658. Found by extending the commandStart linter to proof bodies.
This was referenced Oct 19, 2025
grunweg
pushed a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 19, 2025
Extracted from leanprover-community#30658. Found by extending the commandStart linter to proof bodies.
grunweg
pushed a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 19, 2025
Extracted from leanprover-community#30658. Found by extending the commandStart linter to proof bodies.
grunweg
pushed a commit
to grunweg/mathlib4
that referenced
this pull request
Oct 19, 2025
Extracted from leanprover-community#30658. Found by extending the commandStart linter to proof bodies.
This was referenced Oct 19, 2025
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2025
Extracted from #30658. Found by extending the commandStart linter to proof bodies. Co-authored-by: adomani <adomani@gmail.com>
Collaborator
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_letstactic leanprover/lean4#12006grind_patternleanprover/lean4#11686commandStartlinter towhitespace#33708