Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch primes on List.getElem_take #5294

Merged
merged 1 commit into from
Sep 16, 2024
Merged

chore: switch primes on List.getElem_take #5294

merged 1 commit into from
Sep 16, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 10, 2024 •
edited
Loading

This will probably have fallout downstream, and as it is a direct name switch I'm not going to provide any deprecations.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 10, 2024 06:29 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 10, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Sep 10, 2024 •
edited by leanprover-community-bot
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 5a9cfa0aec2b7b41d925047f1615c6c0290215e9 --onto c96fbdda44c14c7c256f046fb2b71fae25ea968e. (2024-09-10 06:29:39)
  • 💥 Mathlib branch lean-pr-testing-5294 build failed against this PR. (2024-09-16 02:18:29) View Log
  • ✅ Mathlib branch lean-pr-testing-5294 has successfully built against this PR. (2024-09-16 03:20:47) View Log

@kim-em kim-em added this pull request to the merge queue Sep 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 10, 2024
@kim-em kim-em enabled auto-merge September 10, 2024 08:03
@kim-em kim-em disabled auto-merge September 10, 2024 08:07
@kim-em kim-em force-pushed the List.getElem_take_primes branch from 71134c5 to 180c1ce Compare September 10, 2024 08:09
@kim-em kim-em force-pushed the List.getElem_take_primes branch from 180c1ce to 3d539cd Compare September 16, 2024 01:47
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 16, 2024 02:05 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5294
3034fd2
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5294
86d5c98
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 16, 2024
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@kim-em
fixes for leanprover/lean4#5294
bf9487a
@kim-em kim-em added awaiting-mathlib We should not merge this until we have a successful Mathlib build and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Sep 16, 2024
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Sep 16, 2024
@kim-em kim-em added this pull request to the merge queue Sep 16, 2024
Merged via the queue into master with commit 9568f30 Sep 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-mathlib4-bot @leanprover-community-bot