feat: make MessageData.ofConstName be the default coercion from Name to MessageData
#5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me` to `MessageData` Breaking change: use `format n` if a name does not represent a global constant. The only thing that can happen is that, without `format`, if the name is incidentally a global constant it will appear with hover information.
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 19, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 19, 2024
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
breaks-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 20, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 20, 2024
leanprover-community-bot
added
builds-mathlib
nomeata
reviewed
Oct 22, 2024
| @@ -71,7 +71,7 @@ protected def throwError [Monad m] [MonadError m] (msg : MessageData) : m α := | |||
|
|
|||
| /-- Throw an unknown constant error message. -/ | |||
| def throwUnknownConstant [Monad m] [MonadError m] (constName : Name) : m α := | |||
| Lean.throwError m!"unknown constant '{mkConst constName}'" | |||
| Lean.throwError m!"unknown constant '{constName}'" | |||
There was a problem hiding this comment.
Should this be using format?
Suggested change
| Lean.throwError m!"unknown constant '{constName}'" | |
| Lean.throwError m!"unknown constant '{format constName}'" |
There was a problem hiding this comment.
That leads to unknown constant 'x._@.lean.255._hyg.13'. Somehow we need to be able to invoke the name sanitizer here...
I think I'm going to put this PR on hold, since Name is used for a number of things, and I'm afraid there will be surprises down the line. Maybe better would be to get {.ofConstName c} to work and then systematically track down everywhere constants are printed... (Can we rename MessageData.ofConst to MessageData.ofConstExpr and the use MessageData.ofConst for this?)
nomeata
reviewed
Oct 22, 2024
| @@ -92,7 +92,7 @@ def mkAuxName [Monad m] [MonadEnv m] (baseName : Name) (idx : Nat) : m Name := d | |||
| def getConstInfo [Monad m] [MonadEnv m] [MonadError m] (constName : Name) : m ConstantInfo := do | |||
| match (← getEnv).find? constName with | |||
| | some info => pure info | |||
| | none => throwError "unknown constant '{mkConst constName}'" | |||
| | none => throwError "unknown constant '{constName}'" | |||
There was a problem hiding this comment.
Probably
Suggested change
| | none => throwError "unknown constant '{constName}'" | |
| | none => throwError "unknown constant '{format constName}'" |
|
Closed in favor of #5857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a number of error messages, since this makes constants appearing in them hoverable and support "go to definition".
Breaking change: use
format nif a name does not represent a global constant. The only thing that can happen withoutformatis that if the name is incidentally a global constant it will appear with hover information.