-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: USize.size
inequalities
#6203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweak `UInt64.toUSize` def
These inequalities could also be named |
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Nov 24, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 24, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 24, 2024
leanprover-community-bot
added
the
builds-mathlib
CI has verified that Mathlib builds against this PR
label
Nov 25, 2024
Mathlib CI status (docs):
|
kim-em
reviewed
Nov 26, 2024
Co-authored-by: Kim Morrison <kim@tqft.net>
JovanGerb
pushed a commit
to JovanGerb/lean4
that referenced
this pull request
Jan 21, 2025
This PR adds the theorems `le_usize_size` and `usize_size_le`, which make proving inequalities about `USize.size` easier. It also deprecates `usize_size_gt_zero` in favor of `usize_size_pos` (as that seems more consistent with our naming covention) and adds `USize.toNat_ofNat_of_lt_32` for dealing with small USize literals. It also moves `USize.ofNat32` and `USize.toUInt64` to `Init.Data.UInt.Basic` as neither are used in `Init.Prelude` anymore. --------- Co-authored-by: Kim Morrison <kim@tqft.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the theorems
le_usize_size
andusize_size_le
, which make proving inequalities aboutUSize.size
easier.It also deprecates
usize_size_gt_zero
in favor ofusize_size_pos
(as that seems more consistent with our naming covention) and addsUSize.toNat_ofNat_of_lt_32
for dealing with small USize literals.It also moves
USize.ofNat32
andUSize.toUInt64
toInit.Data.UInt.Basic
as neither are used inInit.Prelude
anymore.