Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to BFF Feature proto #274

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

DavidSGK
Copy link
Member

@DavidSGK DavidSGK commented Jan 4, 2024

We want to add metadata to configs returned as responses to GetRepositoryContents such as when it was created and when it was last updated. Later, we could add staleness info here as well.

@DavidSGK DavidSGK self-assigned this Jan 4, 2024
@DavidSGK DavidSGK marked this pull request as ready for review January 4, 2024 17:47
Copy link
Contributor

@lekko-jonathan lekko-jonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of this being a property of Feature rather than a field on the higher object at least initially makes sense to me

@DavidSGK DavidSGK merged commit 51927cf into main Jan 9, 2024
1 check passed
@DavidSGK DavidSGK deleted the david-feature-metadata-protos branch January 9, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants