Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to BFF Feature proto #274

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Add metadata to BFF Feature proto #274

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32061c
Add metadata to BFF Feature proto
DavidSGK Jan 4, 2024
546ea16
Move comment as per feedback
DavidSGK Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions proto/lekko/bff/v1beta1/bff.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,15 @@ message GetFeatureHistoryResponse {
repeated FeatureHistoryItem history = 1;
}

// The configs will have metadata fields populated based on the latest rolled
// out version of the repo.
// If a config was newly created since, created_at will not be set.
// If a config existed already but was updated, last_updated_at will not be set.
message ConfigMetadata {
google.protobuf.Timestamp created_at = 1;
google.protobuf.Timestamp last_updated_at = 2;
}

message Feature {
string name = 1;
string namespace_name = 2;
Expand All @@ -479,6 +488,7 @@ message Feature {
// the blob sha of the proto bin file according to git
string sha = 6;
lekko.feature.v1beta1.StaticFeature static_feature_new = 7;
ConfigMetadata metadata = 8;
}

message FeatureHistoryItem {
Expand Down