Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making MIN_SLEEP_DURATION a platform variable and Add busy wait #403

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Making MIN_SLEEP_DURATION a platform variable and Add busy wait #403

wants to merge 5 commits into from
+31 −24

Conversation

soyerefsane
Copy link
Collaborator

As discussed in #332, I have moved forward to make the following changes for the threaded runtime:

  • If the wait duration is less than MIN_SLEEP_DURATION the wait_until function busy waits until wait_until_time is reached.
  • MIN_SLEEP_DURATION was defined as an arbitrary constant of 10 usec, I changed that to be a platform variable such that the value of MIN_SLEEP_DURATION is equal to underlying system's clock resolution.

@soyerefsane soyerefsane requested a review from edwardalee March 28, 2024 01:43
@soyerefsane soyerefsane added enhancement Enhancement of existing feature bugfix labels Mar 28, 2024
@soyerefsane soyerefsane marked this pull request as draft March 28, 2024 02:07
@soyerefsane
Copy link
Collaborator Author

I made the MIN_SLEEP_DURATION a platform property but realized the clock resolution value was just for Unix-based platforms, WIP is to update the other support files to add the declaration of MIN_SLEEP_DURATION based on their clk resolutions right now.

@soyerefsane soyerefsane removed the request for review from edwardalee March 28, 2024 05:58
edwardalee
edwardalee requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good direction. Suggestions added.

core/threaded/reactor_threaded.c Outdated Show resolved Hide resolved
include/core/reactor_common.h Outdated Show resolved Hide resolved
low_level_platform/api/platform/lf_unix_clock_support.h Outdated Show resolved Hide resolved
low_level_platform/impl/src/lf_unix_clock_support.c Outdated Show resolved Hide resolved
low_level_platform/impl/src/lf_unix_clock_support.c Outdated
@@ -23,6 +25,7 @@ void _lf_initialize_clock() {
}

lf_print("---- System clock resolution: %ld nsec", res.tv_nsec);
MIN_SLEEP_DURATION = NSEC(res.tv_nsec);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation does not match the description of the PR.

@byeonggiljun byeonggiljun mentioned this pull request Jan 28, 2025
Open
@byeonggiljun byeonggiljun linked an issue Jan 28, 2025 that may be closed by this pull request
Optimistic MIN_SLEEP_DURATION causes a problem #513
Open
@byeonggiljun byeonggiljun marked this pull request as ready for review January 28, 2025 18:35
@byeonggiljun byeonggiljun mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byeonggiljun byeonggiljun byeonggiljun left review comments

@edwardalee edwardalee edwardalee requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bugfix enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimistic MIN_SLEEP_DURATION causes a problem
3 participants
@soyerefsane @edwardalee @byeonggiljun