-
Notifications
You must be signed in to change notification settings - Fork 25
Making MIN_SLEEP_DURATION a platform variable and Add busy wait #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soyerefsane
wants to merge
5
commits into
main
Choose a base branch
from
min-sleep-busy-wait
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
22d49a1
made MIN_SLEEP_DURATION a platform property based on clk res
soyerefsane 0fc0a40
Busy wait if the wait time < MIN_SLEEP_DURATION
soyerefsane 61d6ef2
Merge branch 'main' into min-sleep-busy-wait
byeonggiljun bb552dc
Rename `MIN_SLEEP_DURATION` to `lf_min_sleep_duration` and update com…
byeonggiljun c2b5f8d
Apply clang-format
byeonggiljun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,8 @@ | |
#include "logging.h" | ||
#include "platform/lf_unix_clock_support.h" | ||
|
||
instant_t MIN_SLEEP_DURATION; | ||
byeonggiljun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
instant_t convert_timespec_to_ns(struct timespec tp) { return ((instant_t)tp.tv_sec) * BILLION + tp.tv_nsec; } | ||
|
||
struct timespec convert_ns_to_timespec(instant_t t) { | ||
|
@@ -23,6 +25,7 @@ void _lf_initialize_clock() { | |
} | ||
|
||
lf_print("---- System clock resolution: %ld nsec", res.tv_nsec); | ||
MIN_SLEEP_DURATION = NSEC(res.tv_nsec); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This implementation does not match the description of the PR. |
||
} | ||
|
||
/** | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.