Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple errors caught by the SciPy build process #209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jun 16, 2024

  1. Fix a couple errors caught by the SciPy build process

    SciPy complained about "expression result unused" for the extra '(',
    which makes sense.
    
    It also complained about `rc` being unused. This is slightly annoying
    because we put the return value of `prima_minimize` in `result.status`.
    I decided it made sense to return info by itself if there was an error
    in either `init_result` or `check_problem`, and then just return DFT by
    default.
    nbelakovski committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    be6c3d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Trying to fix CI issues

    - gcc 13.3.0 seems to have an issue with math.h on macOS. It spews a
      bunch of errors about the API_DEPRECATED macro not being used
      correctly, which is not an issue on our side. gcc 13.2.0 does not
      seem to have this issue, but since we cannot select gcc with such
      granularity we downgrade to gcc 12 and hope this fixes the issue for
      now.
    
    - numpy 2.0.0 has come out which causes runtime issues. Fortunately the
      fix is easy, just build with pybind11 >=2.12.0. However this is still
      an issue for the pdfo compatibility test since pdfo does not support
      numpy 2.0.0, and sometimes the tests install 2.0.0 because it happens
      to be in the pip cache. So we upgrade pybind11 (the new version is
      compatible with 2.0 and 1.0 numpy) and skip the pdfo test if we
      happened to pick up numpy 2.
    
    - macOS builds for building Python wheels started to complain when running
      the "delocate" step that libquadmath, libstdc++, and libgfortran have
      minimum targets of 11.0, whereas the default was 10.9, hence we added
      the relevant env variable for CIBW.
    
    - Notes have been made in build_python.yml for failures related to
      Ubuntu 24.04.
    
    - A couple tests were failing on macOS 14. I tried to modify rhobeg and
      rhoend, but this ended up turning into a game of whack-a-mole, where a
      rhobeg/rhoend that worked on one architecture would fail on another.
      Ultimaately the most reliable solution I found was to modify the
      starting point to be close to the optimal point.
    nbelakovski committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    90b1af1 View commit details
    Browse the repository at this point in the history