Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new methods are added for Get_popular_teams and search_teams #38

Merged
merged 7 commits into from
Aug 14, 2023

Conversation

shaikhmudassir
Copy link
Contributor

@shaikhmudassir shaikhmudassir commented Aug 8, 2023

Please Review my PR. Implemented the two endpoints for the teams' client #6

  1. get_popular_teams
  2. search_teams

@shaikhmudassir shaikhmudassir changed the title new method is added for Get_popular_teams new methods are added for Get_popular_teams and search_teams Aug 12, 2023
@kraktus kraktus force-pushed the master branch 2 times, most recently from edea02e to b867367 Compare August 14, 2023 16:59
@kraktus
Copy link
Member

kraktus commented Aug 14, 2023

Thanks for the PR! I've added a test for the new endpoint, it's a new good practice! 3e1ac88

@kraktus kraktus merged commit 68a05e0 into lichess-org:master Aug 14, 2023
17 checks passed
shaikhmudassir added a commit to shaikhmudassir/berserk that referenced this pull request Aug 17, 2023
new methods are added for Get_popular_teams and search_teams (lichess-org#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants