[TAS-559] ✨ Enable update ISCN #429
Conversation
AuroraHuang22
commented
Dec 27, 2023
•
AuroraHuang22
commented
AuroraHuang22
force-pushed
the
feature/update-iscn
branch
from
15360e1
to
42fefc3
Compare
utils/cosmos/iscn/sign.ts
Outdated
| gas: UPDATE_ISCN_GAS_FEE.toString(), | ||
| amount: [{ | ||
| denom: DEFAULT_GAS_PRICE[0].denom, | ||
| amount: DEFAULT_GAS_PRICE[0].amount.toString(), |
There was a problem hiding this comment.
need to multiply by GAS_FEE?
There was a problem hiding this comment.
updated 8d4556c
There was a problem hiding this comment.
We can just use signISCN or signISCNTx with iscnId instead of making a new functions
| } | ||
| } | ||
| } else { | ||
| redirect({ name: 'index' }) |
There was a problem hiding this comment.
Prefer calling return right after redirect
| :label="$t('iscn.meta.content.fingerprints')" | ||
| class="mb-[12px]" | ||
| > | ||
| <IscnUploadForm |
There was a problem hiding this comment.
Should we allow direct editijg of content fingerprint/sameAs without going through upload form?
There was a problem hiding this comment.
Currently, we plan to provide only a complete update.
| } | ||
|
|
||
| onSubmitUpload({ fileRecords }: { fileRecords: any[] }) { | ||
| this.contentFingerprints = [] |
There was a problem hiding this comment.
Not sure if we should keep original content fingerprint if upload form is skipped
There was a problem hiding this comment.
The current UI doesn't offer a way to skip uploading. If users want to abandon the process, they need to refresh the page directly.
utils/cosmos/iscn/sign.ts
Outdated
| @@ -169,7 +169,7 @@ export async function signISCN( | |||
| ? signingClient.updateISCNRecord(address, iscnId as string, tx, { | |||
| memo: memo || 'app.like.co', | |||
| fee: { | |||
| gas, | |||
| gas: new BigNumber(gas).multipliedBy(ISCN_GAS_MULTIPLIER).toFixed(0), | |||
There was a problem hiding this comment.
Just increase the default ISCN_GAS_FEE by ISCN_GAS_MULTIPLIER? gas as a input is expected to be override, ISCN_GAS_MULTIPLIER should be applied to the input not inside this function
