Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TAS-559] ✨ Enable update ISCN #429

Merged
merged 14 commits into from
Dec 29, 2023
Merged

[TAS-559] ✨ Enable update ISCN #429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5cb1324
💄 Add entrance for editing ISCN
AuroraHuang22 Dec 27, 2023
3595389
✨ Add [edit/_iscnId] page
AuroraHuang22 Dec 27, 2023
1606cf6
🎨 Handle sign update ISCN
AuroraHuang22 Dec 27, 2023
6b47d12
🚸 Improve the guidance throughout the process
AuroraHuang22 Dec 27, 2023
29d70c1
🐛 Redirect to the latest version
AuroraHuang22 Dec 27, 2023
694d0f5
🎨 Refine the contentMetadata
AuroraHuang22 Dec 28, 2023
d3d3b49
🩹 Increase gas fee
AuroraHuang22 Dec 28, 2023
42fefc3
🐛 Fix incorrect sameAs value
AuroraHuang22 Dec 28, 2023
8d4556c
🎨 Increase gas fee using multiplier
AuroraHuang22 Dec 29, 2023
0db45d1
🎨 End asyncData after the redirect
AuroraHuang22 Dec 29, 2023
c21d525
♻️ Use signISCN update method to update ISCN
AuroraHuang22 Dec 29, 2023
f55e0d3
🔀 Merge main branch updates
AuroraHuang22 Dec 29, 2023
18ad21c
🩹 Increase gas fee for update ISCN
AuroraHuang22 Dec 29, 2023
bc19bb2
🎨 Move iscn multiplier to default param
williamchong Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion constant/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export const ISCN_MIN_BALANCE = 0.01;

export const ISCN_GAS_FEE = 200000;
export const ISCN_GAS_MULTIPLIER = 1.5;
export const UPDATE_ISCN_GAS_FEE = 300000;

export const ISCN_REGISTRY_NAME = 'likecoin-chain';

Expand Down
28 changes: 1 addition & 27 deletions utils/cosmos/iscn/sign.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export async function signISCN(
? signingClient.updateISCNRecord(address, iscnId as string, tx, {
memo: memo || 'app.like.co',
fee: {
gas,
gas: new BigNumber(gas).multipliedBy(ISCN_GAS_MULTIPLIER).toFixed(0),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just increase the default ISCN_GAS_FEE by ISCN_GAS_MULTIPLIER? gas as a input is expected to be override, ISCN_GAS_MULTIPLIER should be applied to the input not inside this function

amount: [{
denom: DEFAULT_GAS_PRICE[0].denom,
amount: new BigNumber(gas).multipliedBy(DEFAULT_GAS_PRICE[0].amount).toFixed(0),
Expand All @@ -190,29 +190,3 @@ export async function signISCN(
return res as DeliverTxResponse
}

export async function updateISCNRecord(
signer: OfflineSigner,
address: string,
iscnId: string,
payload: ISCNSignPayload,
) {
const signingClient = await getSigningClient()
await signingClient.connectWithSigner(network.rpcURL, signer)
const signingPromise = signingClient.updateISCNRecord(
address,
iscnId,
payload,
{
fee: {
gas: (new BigNumber(ISCN_GAS_FEE).times(ISCN_GAS_MULTIPLIER).toFixed(0)).toString(),
amount: [{
denom: DEFAULT_GAS_PRICE[0].denom,
amount: DEFAULT_GAS_PRICE[0].amount.toString(),
}],
},
},
)

const res = await signingPromise
return res as DeliverTxResponse
}
Loading