Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "uninstall" target from the Makefile #390

Closed
wants to merge 1 commit into from

Conversation

nega0
Copy link
Contributor

@nega0 nega0 commented Feb 11, 2025

The "uninstall" target is dangerous as it tries to remove more than what the "install" installs. Also removes the relevant CI workflow step and reference in the README. Preferred to #389.

The "uninstall" target is dangerous as it tries to remove more than what
the "install" installs. Also removes the relevant CI workflow step and
reference in the README.
@henry2cox
Copy link
Collaborator

I'm traveling at the moment - and cannot test or experiment.
Generally: I would prefer to see a change which retains the install/uninstall functionality (after fixing any overly aggressive/incorrect behavior) - rather than removing it.
My concern is that someone, somewhere, is using this feature - and this change will break them.

In any case: it will be a month or so, before I can look at this in detail.
(Sorry)

Henry

henry2cox added a commit to henry2cox/lcov that referenced this pull request Mar 3, 2025
created by 'install' process.  See linux-test-project#389, linux-test-project#390

Signed-off-by:  Henry Cox <henry.cox@mediatek.com>
henry2cox added a commit to henry2cox/lcov that referenced this pull request Mar 4, 2025
created by 'install' process.  See linux-test-project#389, linux-test-project#390

Signed-off-by:  Henry Cox <henry.cox@mediatek.com>
henry2cox added a commit to henry2cox/lcov that referenced this pull request Mar 4, 2025
created by 'install' process.  See linux-test-project#389, linux-test-project#390

Signed-off-by:  Henry Cox <henry.cox@mediatek.com>
henry2cox added a commit to henry2cox/lcov that referenced this pull request Mar 4, 2025
created by 'install' process.  See linux-test-project#389, linux-test-project#390

Signed-off-by:  Henry Cox <henry.cox@mediatek.com>
henry2cox added a commit to henry2cox/lcov that referenced this pull request Mar 4, 2025
created by 'install' process.  See linux-test-project#389, linux-test-project#390

Signed-off-by:  Henry Cox <henry.cox@mediatek.com>
henry2cox added a commit that referenced this pull request Mar 4, 2025
…as created by the install process (#393)

See #389, #390

Signed-off-by: Henry Cox <henry.cox@mediatek.com>
@henry2cox
Copy link
Collaborator

subsumed by #393.
Closing

@henry2cox henry2cox closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants