Less agressive 'uninstall' target: don't remove directory unless it was created by 'install' process. #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
reviewed
Mar 4, 2025
Makefile
Outdated
| @@ -74,6 +74,7 @@ EXES = \ | |||
| # any of their names | |||
| SCRIPTS = $(shell ls scripts | grep -v -E '([\#\~]|\.orig|\.bak|\.BAK)' ) | |||
| LIBS = lcovutil.pm | |||
| MAN_SECTIONS= 1 5 | |||
There was a problem hiding this comment.
Suggested change
| MAN_SECTIONS= 1 5 | |
| MAN_SECTIONS = 1 5 |
?
henry2cox
force-pushed
the
master
branch
2 times, most recently
from
030b9c1 to
3da0633
Compare
hartwork
reviewed
Mar 4, 2025
Makefile
Outdated
|
|
||
| # Program for checking coding style | ||
| CHECKSTYLE = $(CURDIR)/bin/checkstyle.sh | ||
|
|
||
| INSTALL = install | ||
| FIX = $(realpath bin/fix.pl) | ||
| RM = rm | ||
| RM = rm -f | ||
| RMDIR = rmdir --ignore-fail-on-non-empty |
There was a problem hiding this comment.
--ignore-fail-on-non-empty is likely not POSIX (https://pubs.opengroup.org/onlinepubs/009695399/utilities/rm.html)
created by 'install' process. See linux-test-project#389, linux-test-project#390 Signed-off-by: Henry Cox <henry.cox@mediatek.com>
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #389, #390
Signed-off-by: Henry Cox henry.cox@mediatek.com