Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets/herounit-image-with-aside: add title styling and fix copyright #5404

Closed
wants to merge 1 commit into from
Closed

assets/herounit-image-with-aside: add title styling and fix copyright #5404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion meinberlin/assets/scss/components_user_facing/_copyright.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.image__copyright--aside {
.image__copyright.image__copyright--aside {
Copy link
Contributor

@hom3mad3 hom3mad3 Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure about these overwrites. maybe better not use this class at all? also, the font-size of this element is too small. i was wondering if we should create a new herounit-copyright element altogether? this is something i've worked on last week: #5409 we could try to reproduce some of it here? the PR also solves issues with the content-wrapper width.
as for the button design on mobile having being full-width, this will need to be fixed on a4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, and the button icon should be black

position: relative;
right: revert;
bottom: revert;
Expand Down
3 changes: 3 additions & 0 deletions meinberlin/assets/scss/components_user_facing/_herounit-image-with-aside.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.herounit-image-with-aside .title {
margin-bottom: 0.5em;
}
1 change: 1 addition & 0 deletions meinberlin/assets/scss/style_user_facing.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
@import "components_user_facing/control-bar";
@import "components_user_facing/copyright";
@import "components_user_facing/follow";
@import "components_user_facing/herounit-image-with-aside";
@import "components_user_facing/input";
@import "components_user_facing/link--edit";
@import "components_user_facing/moderator_status";
Expand Down