assets/herounit-image-with-aside: add title styling and fix copyright #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d more specific target for copyright fixes #5366
hom3mad3
reviewed
Jan 22, 2024
| @@ -1,4 +1,4 @@ | |||
| .image__copyright--aside { | |||
| .image__copyright.image__copyright--aside { | |||
There was a problem hiding this comment.
i'm not sure about these overwrites. maybe better not use this class at all? also, the font-size of this element is too small. i was wondering if we should create a new herounit-copyright element altogether? this is something i've worked on last week: #5409 we could try to reproduce some of it here? the PR also solves issues with the content-wrapper width.
as for the button design on mobile having being full-width, this will need to be fixed on a4.
There was a problem hiding this comment.
oh, and the button icon should be black
1 task
|
closed in favor of #5409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d more specific target for copyright fixes #5366
Describe your changes
Briefly explain what you did and provide context for a clearer understanding.
Tasks
fix can be seen on project detail http://localhost:8003/projekte/liqd-project/ if project has a header image with copyright
fixed image copyright so can be seen issue - needs image and copyright #5366
expected outcome:
