hero-unit: fix redesign issues #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
philli-m
reviewed
Jan 23, 2024
meinberlin/apps/projects/templates/meinberlin_projects/project_detail.html
Outdated
Show resolved
Hide resolved
meinberlin/apps/projects/templates/meinberlin_projects/project_detail.html
Outdated
Show resolved
Hide resolved
|
Oh and no double up with the tabs PR by the way, thought I wrote that somewhere but it seems lost now?! |
hom3mad3
force-pushed
the
mr-2024-01-project-hero-fixes
branch
3 times, most recently
from
1c6e9da to
9477c80
Compare
philli-m
force-pushed
the
mr-2024-01-project-hero-fixes
branch
from
9477c80 to
d38319a
Compare
philli-m
reviewed
Jan 31, 2024
| @@ -1,10 +1,16 @@ | |||
| .follow__container > span { | |||
| width: 100%; | |||
| } | |||
There was a problem hiding this comment.
@hom3mad3 this span is the data widget from the template ta hence no class and as it is an inline element it had a limited width (i think anyway) so it was also limiting the nested elements
philli-m
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hero-unit: redesign fixes
possible duplicate of: #5406 and #5404
Tasks