Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets/tabs-tabnavigation: change element name and implement tab styl… #5406

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Jan 22, 2024

…ing copied from berlin.de site fixes #5364

Describe your changes
Briefly explain what you did and provide context for a clearer understanding.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

fixe can be seen on project detail http://localhost:8003/projekte/liqd-project/

implemented BO tab styling after they included similar tabs on berlin.de fixes #5364 / #5379

expected outcome:
screenshot(29)

@philli-m philli-m requested a review from hom3mad3 January 22, 2024 10:42
@hom3mad3 hom3mad3 mentioned this pull request Jan 22, 2024
1 task
@philli-m philli-m force-pushed the pm-2023-12-add-bo-tab-styles branch 2 times, most recently from 78a69e9 to ff91503 Compare January 23, 2024 15:24
@philli-m philli-m force-pushed the pm-2023-12-add-bo-tab-styles branch from ff91503 to 320a802 Compare January 23, 2024 17:16
@philli-m
Copy link
Contributor Author

@hom3mad3 I think this is ready again?!

@philli-m philli-m requested a review from hom3mad3 January 23, 2024 17:17
@hom3mad3 hom3mad3 merged commit bce5cd3 into dev Jan 30, 2024
2 checks passed
@hom3mad3 hom3mad3 deleted the pm-2023-12-add-bo-tab-styles branch January 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants