Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit and invariants #62

Merged
merged 122 commits into from
Nov 13, 2024
Merged

Fix audit and invariants #62

merged 122 commits into from
Nov 13, 2024

Conversation

GalloDaSballo
Copy link
Collaborator

@GalloDaSballo GalloDaSballo commented Oct 29, 2024

Latest Invariant Tests

Optimization: https://getrecon.xyz/shares/4322cb57-533a-46ff-9bd8-4703aea725dd

Assertion (includes 2 tests to try shrinking the Optimizations as well as overflow and revert checks on voting power math computation): https://getrecon.xyz/shares/638cd7c3-d0ca-43c4-89f8-54ef14105624

Latest tests
https://getrecon.xyz/shares/f45f74d6-ad31-4db5-8b37-f30e1a5d6018

Fix Properties

#58

Prelim Review Fixes

#59

Experimental Reset All votes

#61

DD FSM Fix

https://gist.github.com/GalloDaSballo/1bbc4f0a03ef0b159f99a222f8f69f1f

#64

Bribes alignment fix, revert properties and Crit Repro on causing system insolvency

#67

TODO

  • Review Invariant Tests (Medusa seems to have false positives)
  • Review Coverage
  • Reason through flows
  • Ensure that no insolvency can happen
  • Limit rounding errors and find a test to "ensure they are constrained"
  • Test relative Bribes Ratio, ensure this ratio is constant and cannot be changed with time
  • Test relative Bribes Claim Ratio, ensure this ratio is constant and cannot be changed with time
  • Risks tied to voting power changes -> We should see if a FL can in any way impact this, should be mitigated now that we enforce resets on all operations
  • Risks tied to rounding around voting power -> We should model this, possibly by adding higher precision?
  • Increase precision on all timestamps
  • Demonstrate (via Invariant Tests) that the maximum error is below 1e19 (With a 1e26 scale)

@danielattilasimon danielattilasimon merged commit 8ee01de into dev Nov 13, 2024
2 of 3 checks passed
@danielattilasimon danielattilasimon deleted the fix-audit-and-invariants branch November 13, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants