Code

Fix audit and invariants#62

Code

Merged

danielattilasimon merged 122 commits intodevliquity/V2-gov:devfrom fix-audit-and-invariantsliquity/V2-gov:fix-audit-and-invariantsCopy head branch name to clipboardNov 13, 2024

+2,168-808

Commits

Commits on Oct 28, 2024

• feat: test that shows bug in total voting power

  GalloDaSballo

  committed
  ab6e95c

  Copy full SHA for ab6e95c

• feat: minimal extra test to check DISABLED math accounting

  GalloDaSballo

  committed
  92a5b07

  Copy full SHA for 92a5b07

• fix: incorrect accounting from DISABLED initiatives

  GalloDaSballo

  committed
  429f02f

  Copy full SHA for 429f02f

• chore: cleanup

  GalloDaSballo

  committed
  3a529e6

  Copy full SHA for 3a529e6

• polish: explicit non negative checks

  GalloDaSballo

  committed
  28ee9fe

  Copy full SHA for 28ee9fe

• chore: audit tags

  GalloDaSballo

  committed
  8c35064

  Copy full SHA for 8c35064

• Merge branch 'dev' of github.com:liquity/V2-gov into dev-fix-properties

  GalloDaSballo

  committed
  6700b41

  Copy full SHA for 6700b41

• fix: use calldata to check dups

  GalloDaSballo

  committed
  7859f62

  Copy full SHA for 7859f62

• fix: use _encodeLQTYAllocation

  GalloDaSballo

  committed
  c8b5ec3

  Copy full SHA for c8b5ec3

• fix: edge case of remainer

  GalloDaSballo

  committed
  8865787

  Copy full SHA for 8865787

• feat: use remainer and amount

  GalloDaSballo

  committed
  d5838a8

  Copy full SHA for d5838a8

Commits on Oct 29, 2024

• chore: rename _deposit

  GalloDaSballo

  committed
  9ad09cf

  Copy full SHA for 9ad09cf

• chore: cleanup

  GalloDaSballo

  committed
  8e6a645

  Copy full SHA for 8e6a645

• feat: stateful test for reset soundness

  GalloDaSballo

  committed
  0266514

  Copy full SHA for 0266514

• chore: undo yolo reset change

  GalloDaSballo

  committed
  aff1bef

  Copy full SHA for aff1bef

• feat: can be reprod manually

  GalloDaSballo

  committed
  4a73edc

  Copy full SHA for 4a73edc

• chore: repro

  GalloDaSballo

  committed
  432e88c

  Copy full SHA for 432e88c

• chore: future notes on V2 Gauge

  GalloDaSballo

  committed
  5a82349

  Copy full SHA for 5a82349

• chore: make tests compile

  GalloDaSballo

  committed
  696cfde

  Copy full SHA for 696cfde

• feat: aded reset alloc calls

  GalloDaSballo

  committed
  66a29a0

  Copy full SHA for 66a29a0

• feat: new property for reset

  GalloDaSballo

  committed
  5cfeff0

  Copy full SHA for 5cfeff0

• chore: comments

  GalloDaSballo

  committed
  b2972be

  Copy full SHA for b2972be

• Merge branch 'cs-prelim-fixes' into fix-audit-and-invariants

  GalloDaSballo

  committed
  5ac7754

  Copy full SHA for 5ac7754

• Merge branch 'exp-reset-all' into fix-audit-and-invariants

  GalloDaSballo

  committed
  2f59274

  Copy full SHA for 2f59274

• chore: comment

  GalloDaSballo

  committed
  81f3e55

  Copy full SHA for 81f3e55

Commits on Oct 30, 2024

• chore: spaces

  GalloDaSballo

  committed
  a4a40bf

  Copy full SHA for a4a40bf

• feat: registerable test

  GalloDaSballo

  committed
  640208d

  Copy full SHA for 640208d

• fix: governance UNREGISTER fsm

  GalloDaSballo

  committed
  11d65f4

  Copy full SHA for 11d65f4

• feat: allocation reset check is optional

  GalloDaSballo

  committed
  cb0c95a

  Copy full SHA for cb0c95a

• chore: remove old repro

  GalloDaSballo

  committed
  14e147e

  Copy full SHA for 14e147e

• chore: clean up shadowing

  GalloDaSballo

  committed
  626f507

  Copy full SHA for 626f507

• chore: cleanuo

  GalloDaSballo

  committed
  f9628e8

  Copy full SHA for f9628e8

• Merge pull request #64 from liquity/fix-dd-review

  Show description for d3ff4af
  GalloDaSballo

  authored
  d3ff4af

  Copy full SHA for d3ff4af

• chore: cleanup

  GalloDaSballo

  committed
  78688ab

  Copy full SHA for 78688ab

Commits on Oct 31, 2024

• feat: alignment

  GalloDaSballo

  committed
  ef8bd64

  Copy full SHA for ef8bd64

• feat: repro of insolvency property

  GalloDaSballo

  committed
  afc0eea

  Copy full SHA for afc0eea

• chore: compilation

  GalloDaSballo

  committed
  14a5030

  Copy full SHA for 14a5030

• chore: repro

  GalloDaSballo

  committed
  2a27ce6

  Copy full SHA for 2a27ce6

• fix: property specification ignored DISABLED initiatives

  GalloDaSballo

  committed
  79cc29f

  Copy full SHA for 79cc29f

• fix: needless empty values

  GalloDaSballo

  committed
  0b899e8

  Copy full SHA for 0b899e8

• chore: remove shadowing

  GalloDaSballo

  committed
  998cd9f

  Copy full SHA for 998cd9f

• feat: debug BI07

  GalloDaSballo

  committed
  2378fcc

  Copy full SHA for 2378fcc

• feat: additional optimization tests

  GalloDaSballo

  committed
  d622bd5

  Copy full SHA for d622bd5

• chore: opt

  GalloDaSballo

  committed
  cca360b

  Copy full SHA for cca360b

• chore: default to optimization

  GalloDaSballo

  committed
  d8f97ce

  Copy full SHA for d8f97ce

• fix: BribeInitiativeAllocate tests

  nican0r

  committed
  d29f57c

  Copy full SHA for d29f57c

• Merge branch 'fix-temp-invariant-align-bribes' of https://github.com/liquity/V2-gov into fix-temp-invariant-align-bribes

  nican0r

  committed
  c931d57

  Copy full SHA for c931d57

• feat: revert properties for all tests

  GalloDaSballo

  committed
  3f7705a

  Copy full SHA for 3f7705a

• Merge pull request #67 from liquity/fix-temp-invariant-align-bribes

  Show description for 33ece7f
  GalloDaSballo

  authored
  33ece7f

  Copy full SHA for 33ece7f

• chore: cleanup

  GalloDaSballo

  committed
  e1df25c

  Copy full SHA for e1df25c

• chore: e2E

  GalloDaSballo

  committed
  b18c629

  Copy full SHA for b18c629

• fix: cap amount for bribes

  GalloDaSballo

  committed
  f693d5f

  Copy full SHA for f693d5f

• chore: desc

  GalloDaSballo

  committed
  01457bd

  Copy full SHA for 01457bd

Commits on Nov 1, 2024

• feat: upscale ts to u120

  GalloDaSballo

  committed
  a589a29

  Copy full SHA for a589a29

• feat: tests somewhat compile

  GalloDaSballo

  committed
  7e777ae

  Copy full SHA for 7e777ae

• feat: invariants compile and have a few TS tests

  GalloDaSballo

  committed
  d27487f

  Copy full SHA for d27487f

• chore: easy tests are fixed

  GalloDaSballo

  committed
  5d69f9a

  Copy full SHA for 5d69f9a

• chore: fix mock tests

  GalloDaSballo

  committed
  4b75ce1

  Copy full SHA for 4b75ce1

• fix: epochStart is magnified with a hacky solution

  GalloDaSballo

  committed
  7c8a577

  Copy full SHA for 7c8a577

• fix: test ts are magnified

  GalloDaSballo

  committed
  105bc32

  Copy full SHA for 105bc32

• chore: fix overflow

  GalloDaSballo

  committed
  075bf4b

  Copy full SHA for 075bf4b

• fix: abi decode

  GalloDaSballo

  committed
  dc845b3

  Copy full SHA for dc845b3

• fix: BI-07

  GalloDaSballo

  committed
  28fe9d9

  Copy full SHA for 28fe9d9

• WARNING: Add tollerance

  GalloDaSballo

  committed
  56d8e86

  Copy full SHA for 56d8e86

• feat: laxer property

  GalloDaSballo

  committed
  d82a0c3

  Copy full SHA for d82a0c3

• feat: debug and fix properties

  GalloDaSballo

  committed
  6482f51

  Copy full SHA for 6482f51

• fix: BI07

  GalloDaSballo

  committed
  4db439e

  Copy full SHA for 4db439e

• feat: truncation but maybe not so bad

  GalloDaSballo

  committed
  723e9e1

  Copy full SHA for 723e9e1

• fix: we need a higher confidence range

  GalloDaSballo

  committed
  90af7db

  Copy full SHA for 90af7db

• feat: raise the precision to 1e26

  GalloDaSballo

  committed
  d559696

  Copy full SHA for d559696

• fix: upscale the precision in bribes

  GalloDaSballo

  committed
  81c048e

  Copy full SHA for 81c048e

• chore: fix tests

  GalloDaSballo

  committed
  50933d0

  Copy full SHA for 50933d0

• feat: trying out overflow mode

  GalloDaSballo

  committed
  bd2cc0a

  Copy full SHA for bd2cc0a

• chore: cleanup

  GalloDaSballo

  committed
  0572a61

  Copy full SHA for 0572a61

• feat: document overflow risks

  GalloDaSballo

  committed
  9259e26

  Copy full SHA for 9259e26

• fix: overflow in timestamp math

  GalloDaSballo

  committed
  ceffe66

  Copy full SHA for ceffe66

• chore: type consistency

  GalloDaSballo

  committed
  426de19

  Copy full SHA for 426de19

• fix: ensure user TS never decreases

  GalloDaSballo

  committed
  3ecb7a2

  Copy full SHA for 3ecb7a2

• chore: comments on overflow risk

  GalloDaSballo

  committed
  26d4414

  Copy full SHA for 26d4414

• gas: order of operations

  GalloDaSballo

  committed
  55b94aa

  Copy full SHA for 55b94aa

• chore: rename fn

  GalloDaSballo

  committed
  9548318

  Copy full SHA for 9548318

• chore: order of operations for gas

  GalloDaSballo

  committed
  0246b32

  Copy full SHA for 0246b32

• chore: consistent types

  GalloDaSballo

  committed
  3205922

  Copy full SHA for 3205922

• chore: added precision invariant on getInitiativeState

  GalloDaSballo

  committed
  84fcb22

  Copy full SHA for 84fcb22

• chore: custom precision change

  GalloDaSballo

  committed
  f4b1419

  Copy full SHA for f4b1419

• chore: remove property that doesn't really work

  GalloDaSballo

  committed
  04d1b16

  Copy full SHA for 04d1b16

• feat: add a few revert tests that can help detect overflows

  GalloDaSballo

  committed
  1ea9df5

  Copy full SHA for 1ea9df5

• chore: undo de-optimizations

  GalloDaSballo

  committed
  7c96bc7

  Copy full SHA for 7c96bc7

• chore: recommendation

  GalloDaSballo

  committed
  f210e44

  Copy full SHA for f210e44

• chore: cleanup

  GalloDaSballo

  committed
  e553fea

  Copy full SHA for e553fea

Commits on Nov 2, 2024

• fix: approve for bribes

  GalloDaSballo

  committed
  d762007

  Copy full SHA for d762007

• fix: clamped claim

  GalloDaSballo

  committed
  1219a02

  Copy full SHA for 1219a02

• chore: cleanup and simplification

  GalloDaSballo

  committed
  7742491

  Copy full SHA for 7742491

• feat: repro for claim bribe

  GalloDaSballo

  committed
  4ded0c7

  Copy full SHA for 4ded0c7

• feat: extra config for running locally

  GalloDaSballo

  committed
  d60587e

  Copy full SHA for d60587e

• chore: undo config changes

  GalloDaSballo

  committed
  28d6425

  Copy full SHA for 28d6425

• feat: add solvency tests for Governance

  GalloDaSballo

  committed
  d904b26

  Copy full SHA for d904b26

• feat: insolvency optimization tests

  GalloDaSballo

  committed
  96de709

  Copy full SHA for 96de709

• chore: improved coverage and removed canaries

  GalloDaSballo

  committed
  1f0b310

  Copy full SHA for 1f0b310

Commits on Nov 3, 2024

• chore: make precision public

  GalloDaSballo

  committed
  2bfb2b9

  Copy full SHA for 2bfb2b9

• chore: local echidna command

  GalloDaSballo

  committed
  eb42ca1

  Copy full SHA for eb42ca1

• cleanup: remove debugged properties

  GalloDaSballo

  committed
  4d5526f

  Copy full SHA for 4d5526f

• fix: remove BI11

  GalloDaSballo

  committed
  b1b5b2b

  Copy full SHA for b1b5b2b

• fix: Total and Initiative math can only be compared on state, not snapshot

  GalloDaSballo

  committed
  36ae4c6

  Copy full SHA for 36ae4c6

• fix: optimization properties to use state values

  GalloDaSballo

  committed
  f483b06

  Copy full SHA for f483b06

• chore: comment on possible more checks

  GalloDaSballo

  committed
  29471b2

  Copy full SHA for 29471b2

• Merge pull request #68 from liquity/fix-temp-invariant-align-bribes

  Show description for 9bc1dd9
  GalloDaSballo

  authored
  9bc1dd9

  Copy full SHA for 9bc1dd9

• chore: informational

  GalloDaSballo

  committed
  2f1abb7

  Copy full SHA for 2f1abb7

• :wq

  Show description for c4814c0
  GalloDaSballo

  committed
  c4814c0

  Copy full SHA for c4814c0

• feat: assertion for optimization properties

  GalloDaSballo

  committed
  e3c7bdd

  Copy full SHA for e3c7bdd

• feat: additional explicit overflow checks

  GalloDaSballo

  committed
  56a0595

  Copy full SHA for 56a0595

• chore: more lower threshold canaries for optimiztion

  GalloDaSballo

  committed
  1a1bd97

  Copy full SHA for 1a1bd97

Commits on Nov 4, 2024

• chore: config reset

  GalloDaSballo

  committed
  7f6565c

  Copy full SHA for 7f6565c

• feat: debugging of broken properties

  GalloDaSballo

  committed
  f510655

  Copy full SHA for f510655

• chore: force specific repro

  GalloDaSballo

  committed
  9eee4bf

  Copy full SHA for 9eee4bf

• feat: rational checks for deposit max

  GalloDaSballo

  committed
  44359de

  Copy full SHA for 44359de

• feat: repro for max impact

  GalloDaSballo

  committed
  dd6edc6

  Copy full SHA for dd6edc6

• feat: fully shrunken sequence

  GalloDaSballo

  committed
  de65c89

  Copy full SHA for de65c89

• feat: remove incorrectly broken properties

  GalloDaSballo

  committed
  ebba848

  Copy full SHA for ebba848

• chore: remove unused tests

  GalloDaSballo

  committed
  953a3ef

  Copy full SHA for 953a3ef

Commits on Nov 13, 2024

• Merge pull request #70 from liquity/fix-broken-properties

  Show description for a255f05
  danielattilasimon

  authored
  a255f05

  Copy full SHA for a255f05

• chore: forge fmt

  danielattilasimon

  committed
  77ecdbd

  Copy full SHA for 77ecdbd