[CreateSiFiveMetadata] Generate firrtl.class instead of om.class #6736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
reviewed
Feb 22, 2024
prithayan
force-pushed
the
dev/pbarua/om-metadata
branch
from
e7fc23e to
bdb3a0b
Compare
prithayan
force-pushed
the
dev/pbarua/om-metadata
branch
from
bdb3a0b to
7f369c6
Compare
prithayan
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
prithayan
force-pushed
the
dev/pbarua/om-metadata
branch
from
d376c05 to
369ce58
Compare
mikeurbach
reviewed
Apr 2, 2024
Thanks Mike, yes, this is ready for final review. |
mikeurbach
reviewed
Apr 2, 2024
|
Thanks Mike, yes this pass is updating the hierarchy, the analysis is no longer preserved. |
mikeurbach
approved these changes
Apr 3, 2024
prithayan
force-pushed
the
dev/pbarua/om-metadata
branch
from
7533430 to
20fccce
Compare
cepheus69
pushed a commit
to cepheus69/circt
that referenced
this pull request
Apr 22, 2024
…vm#6736) Update the object model generated by the CreateSiFiveMetadata pass to generate firrtl dialect, instead of om dialect. Ensure all firrtl.class associated with the metadata are instantiated inside a top level firrtl.class SiFive_Metadata, which is instantiated inside the top level firrtl.module. This is required for ensuring that subsequent passes can lower it correctly. Also generate all the hierarchical paths to the memory and associates them with the path operation for the memory metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the object model generated by the CreateSiFiveMetadata pass to generate
firrtldialect, instead ofomdialect.Ensure all
firrtl.classassociated with the metadata are instantiated inside a top levelfirrtl.classSiFive_Metadata, which is instantiated inside the top levelfirrtl.module. This is required for ensuring that subsequent passes can lower it correctly.Generate all the hierarchical paths to the memory and associate them with the path operation for the memory metadata.