Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calyx] Fix memory import locations #6769

Merged
merged 2 commits into from
Feb 29, 2024
Merged

[Calyx] Fix memory import locations #6769

merged 2 commits into from
Feb 29, 2024

Conversation

andrewb1999
Copy link
Contributor

Updates memory import locations to be correct for the current calyx native compiler main.

mikeurbach
mikeurbach approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been keeping up, but makes sense to me.

@rachitnigam
Copy link
Contributor

LGTM!

@andrewb1999 andrewb1999 merged commit d5c4b70 into llvm:main Feb 29, 2024
4 checks passed
@andrewb1999 andrewb1999 deleted the fix-export-imports branch March 15, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbach mikeurbach mikeurbach approved these changes

@cgyurgyik cgyurgyik cgyurgyik approved these changes

@rachitnigam rachitnigam Awaiting requested review from rachitnigam rachitnigam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewb1999 @rachitnigam @mikeurbach @cgyurgyik