[Calyx] Lower SCF parallel op to Calyx #7830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgyurgyik
reviewed
Nov 17, 2024
| rewriter.setInsertionPointToEnd(calyxParOp.getBodyBlock()); | ||
| auto seqOp = rewriter.create<calyx::SeqOp>(parOp.getLoc()); | ||
| rewriter.setInsertionPointToEnd(seqOp.getBodyBlock()); | ||
| res = scheduleBasicBlock(rewriter, path, seqOp.getBodyBlock(), |
There was a problem hiding this comment.
Don't you need to check this upon each iteration instead of overwriting it?
jiahanxie353
force-pushed
the
scf-to-calyx-par-pr
branch
from
9058f94 to
641d8ef
Compare
cgyurgyik
reviewed
Nov 18, 2024
|
thanks @cgyurgyik ! just fixed again based on your new review |
cgyurgyik
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch lowers
scf::parallelto Calyx, assuming that all induction variables can be statically derived and thatscf::reducedoes not have operands.