[FIRRTL] Lower firrtl.formal to verif.formal #7836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a lowering from `firrtl.formal` to `verif.formal` in the FIRRTL-to-HW conversion. The lowering creates a `verif.formal` op that simply instantiates the module pointed to by `firrtl.formal`, with symbolic values providing the inputs to the module. We may want to inline the instance in the future, but that is purely cosmetic. This now allows FIR files to contain `formal` unti tests that can be lowered to HW through `firtool` and then executed using `circt-test`.
maerhart
approved these changes
Nov 21, 2024
| auto builder = OpBuilder::atBlockEnd(topLevelModule); | ||
| auto newFormalOp = builder.create<verif::FormalOp>( | ||
| oldFormalOp.getLoc(), oldFormalOp.getNameAttr()); | ||
| newFormalOp->setDiscardableAttrs(oldFormalOp.getParametersAttr()); |
There was a problem hiding this comment.
Maybe we want some ODS verified dictionary attribute for the verif.formal op instead of using a discardable attribute?
There was a problem hiding this comment.
We should definitely do that. I'll add that in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a lowering from
firrtl.formaltoverif.formalin the FIRRTL-to-HW conversion. The lowering creates averif.formalop that simply instantiates the module pointed to byfirrtl.formal, with symbolic values providing the inputs to the module. We may want to inline the instance in the future, but that is purely cosmetic.This now allows FIR files to contain
formalunti tests that can be lowered to HW throughfirtooland then executed usingcirct-test.