[HWToBTOR2] Fix slice lowering argument meanings #7842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like HWToBTOR2 currently implements the wrong semantics for slice in BTOR2 - we assume that BTOR2's slice operation takes the same arguments as our extract (the lowbit and the width) but it actually requires the upper and lower bits of the slice.
For example:
currently lowers to
which when given to Btor-mc throws
as it's expecting the 3rd argument of the slice to be the upper bit so it should be greater than the 4th.