[HWToBTOR2] Fix crashes on initial value corner cases #7844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently HWToBTOR2 crashes on both of the included error cases:
unwrapImmutableValue
throws an assert whenever it's given a value that wasn't defined by an initialOp, so I've added a check for that. While the first error case isn't technically legal anyway as instance ops aren't allowed in HWToBTOR2, the pass currently crashes before it gets to that point.