Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTG][RTGTest] Add Python Bindings #7883

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

maerhart
Copy link
Member

No description provided.

@maerhart maerhart added the RTG Involving the `rtg` dialect label Nov 24, 2024
@maerhart maerhart changed the title [RTG] Add Python Bindings [RTG][RTGTest] Add Python Bindings Nov 24, 2024
@maerhart maerhart force-pushed the maerhart-rtg-python-bindings branch 2 times, most recently from 4469a95 to c2d53a7 Compare November 24, 2024 14:51
@maerhart maerhart force-pushed the maerhart-rtg-python-bindings branch from c2d53a7 to a74719f Compare December 2, 2024 09:58
@maerhart maerhart force-pushed the maerhart-rtg-python-bindings branch from a74719f to 3a32905 Compare December 2, 2024 10:11
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits but python binding looks great to me!

lib/Bindings/Python/RTGModule.cpp Show resolved Hide resolved
lib/Bindings/Python/RTGModule.cpp Outdated Show resolved Hide resolved
@maerhart maerhart force-pushed the maerhart-rtg-python-bindings branch from 3a32905 to dc0a0f0 Compare December 3, 2024 21:09
@maerhart maerhart force-pushed the maerhart-rtg-python-bindings branch from dc0a0f0 to ebf8a7a Compare December 3, 2024 21:53
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from maerhart-rtg-capi to main December 4, 2024 21:39
@maerhart maerhart merged commit 69b551d into main Dec 4, 2024
4 checks passed
@maerhart maerhart deleted the maerhart-rtg-python-bindings branch December 4, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RTG Involving the `rtg` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants