Skip to content

[HW] ExportHier: do not include bound in modules #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

[HW] ExportHier: do not include bound in modules #7915

merged 1 commit into from
Nov 28, 2024

Conversation

youngar
Copy link
Member

@youngar youngar commented Nov 28, 2024

No description provided.

@youngar youngar added the HW Involving the `hw` dialect label Nov 28, 2024
@youngar youngar requested a review from darthscsi as a code owner November 28, 2024 01:04
seldridge
seldridge approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

This is a file format we define and if we want to change it in this way, that's fine.

Does the test fail without the change? Some of those CHECK-SAME checks may need one or more CHECK-NOTs interleaved.

@youngar
Copy link
Member Author

youngar commented Nov 28, 2024 •
edited
Loading

Woops yeah, I think I was reading those as CHECK-NEXT: and not CHECK-SAME:.

@youngar youngar merged commit 99930ad into llvm:main Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
HW Involving the `hw` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngar @seldridge