Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scalar overload name constructed by ReplaceWithVeclib.cpp #111095
base: main
Are you sure you want to change the base?
Fix scalar overload name constructed by ReplaceWithVeclib.cpp #111095
Changes from 1 commit
8227c91
f0557de
2c70285
5e92c3d
9adc046
6a07812
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any tests, testing this logic? I think the pow case is working thanks to the condition added to line 114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
pow
case is impacted by both this logic and return type logic, sinceOloadTys
should include only the return type forpow
, not each of the argument types.isVectorIntrinsicWithOverloadTypeAtArg()
is how you determine the arguments that the intrinsic is overloaded on, when notvoid
, and defaults to -1 (return type).Other tests will be running through this logic (and turning out the same), but the pow one is the only case with two arguments which had existing tests meant to match a vector lib call right now.
atan2
will be added soon, which also needs this. Other intrinsics could require this change in theory, if there's a matching vector lib call for them.