Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8689u4y60 fix boundary saved after cleared #347

Merged
merged 8 commits into from
Sep 30, 2024
Merged

#8689u4y60 fix boundary saved after cleared #347

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7c046df
feat: when "Clear Boundary" button is cliced, the BoundaryPayload is …
lc-hd Sep 23, 2024
f207bfb
feat: code does not attempt to save boundary payload when it is an em…
lc-hd Sep 23, 2024
4603ac8
feat: added data-test-id to reference element
lc-hd Sep 27, 2024
593ce0d
feat: created testcase which verifies cleared boundaries are not saved
lc-hd Sep 27, 2024
39fbe56
feat: added similar testcase but for institutions
lc-hd Sep 30, 2024
c7438dd
Merge pull request #350 from localcontexts/8689u4y60-fix-boundary-sav…
lc-hd Sep 30, 2024
f86731d
feat: updated name of testcase
lc-hd Sep 30, 2024
a3722d0
feat: updated testcase name
lc-hd Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helpers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ def create_or_update_boundary(

raw_boundary_payload = post_data.get('boundary-payload')

if raw_boundary_payload in ['', None]:
if raw_boundary_payload in ['', '{}', None]:
return

data = json.loads(raw_boundary_payload)
Expand Down
2 changes: 2 additions & 0 deletions templates/boundary/update-boundary-via-native-land-and-shapefile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,8 @@
clearShapeFileInput(selectionUnit)
selectInitialShareBoundaryPublicly()
disableContinueButton()
BoundaryPayLoad = {}
setBoundaryPayloadForInputElement()
}
</script>
<script src="{% static 'javascript/shpjs.js' %}"></script>
Loading