Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page number on browse page not in URL anymore #2024

Closed
chaoran-chen opened this issue May 27, 2024 · 3 comments · Fixed by #2290
Closed

Page number on browse page not in URL anymore #2024

chaoran-chen opened this issue May 27, 2024 · 3 comments · Fixed by #2290
Labels
website Tasks related to the web application

Comments

@chaoran-chen
Copy link
Member

chaoran-chen commented May 27, 2024

Since (I assume) #1890, the page number is not stored in the URL anymore. Previously, when one goes to page 2, the URL would contain page=2. This is quite useful in my opinion: first, one can send a direct link to a particular page, and second, how I noticed this, it is an easy way to jump to a particular page (especially since we don't have a feature to do that otherwise). Further, at the moment, reloading the page always resets to the first page which I find quite annoying.

@chaoran-chen chaoran-chen added the website Tasks related to the web application label May 27, 2024
@chaoran-chen chaoran-chen added this to the MVP (nice to have) milestone May 27, 2024
@theosanderson
Copy link
Member

Yes, I was aware of this - I couldn't think of a case where page would be that useful in the URL (because searches change over time) so didn't prioritise it - but I'm very happy to implement that and it would be easy.

@corneliusroemer
Copy link
Contributor

Agreed that it would be nice to have page in URL - but important to clear the page whenever one changes any of:

  • sort order
  • sort column
  • search filters

I remember in a previous version, the page was kept in URL even after one changed sort order which was confusing. I was about to open an issue for that but realized it's no longer a thing on main (I must have looked at an old version, maybe the demo)

@theosanderson
Copy link
Member

@corneliusroemer - I think it is still a thing on main, having just checked :) Thanks for raising

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Tasks related to the web application
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants