Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): User page improvements #1224

Merged
merged 19 commits into from
Mar 9, 2024
Merged

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Mar 4, 2024

resolves #1215, resolves #1178, resolves #829, resolves #742

preview URL: https://userpage-improvements.loculus.org/

Summary

  • improves appearance of account page
  • creates link to keycloak account console
  • deletes old sequence overview page
  • removes a lot of submit / manage sequence stuff from the account page
  • creates a placeholder "submission portal" page, linking to the various submit / manage sequence stuff
  • removes revise page from menu

Screenshot

image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Mar 4, 2024
@theosanderson theosanderson mentioned this pull request Mar 4, 2024
5 tasks
@theosanderson theosanderson changed the title wip: user page improvements User page improvements Mar 4, 2024
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

website/src/components/User/ListOfGroupsOfUser.tsx Outdated Show resolved Hide resolved
website/src/pages/[organism]/submission/index.astro Outdated Show resolved Hide resolved
website/tests/pages/user/userPage/userPage.ts Outdated Show resolved Hide resolved
@fengelniederhammer
Copy link
Contributor

I think this could also close #1124 AFAICS?

@theosanderson
Copy link
Member Author

This is just a placeholder for doing #1124 properly with a nice design

@theosanderson theosanderson changed the title User page improvements feat(website): User page improvements Mar 9, 2024
@theosanderson theosanderson merged commit bc1f4b0 into main Mar 9, 2024
14 checks passed
@theosanderson theosanderson deleted the userpage-improvements branch March 9, 2024 20:38
@theosanderson theosanderson restored the userpage-improvements branch March 9, 2024 20:39
@theosanderson theosanderson deleted the userpage-improvements branch March 9, 2024 20:39
@corneliusroemer
Copy link
Contributor

Looks great, just a few comments/questions:

  • The submit button in top nav now redirects to the submission portal. This means one more click to actually submit which makes it harder to submit for first users. Do we have an issue to track making the submission smooth (again)?
image - The top nav "submit" seems to direct to different pages, depending on where you come from. E.g. from main `/` you go to `/submission/submit`, but from `mpox/search?` I end up on `/submission`

@theosanderson
Copy link
Member Author

#1124 is to track making a "real" submission portal, with nicer UX. It will still be an extra click though - which I think is OK, and part of the (updated) figma design.

@theosanderson
Copy link
Member Author

theosanderson commented Mar 9, 2024

  • The top nav "submit" seems to direct to different pages, depending on where you come from. E.g. from main / you go to /submission/submit, but from mpox/search? I end up on /submission

Yes, we should probably update the organism selector to point to /submission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
3 participants