-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config, remove deployment, add revoke cronjob #2473
Conversation
I had to add the approve step or jobs were starting very quickly after submission and I could still see concurrency - adding the approve step ensures jobs will run for the full 30minutes. |
Nice! What about making approve quit by itself after 25 minutes? Then we get happy ending and not the kill from kubernetes. |
Sadly even with Update: extensive testing in #2478 (comment) has shown that argocd is actually restarting jobs on resync this just isn't displayed that well |
resolves #1777
preview URL: https://ingest-deployment.loculus.org/
Summary
Screenshot
PR Checklist
- hope it is not an issue
kubectl create job --from=cronjob/loculus-revoke-and-regroup-cronjob-{config.organism} <manual-job-name>
Start works:
, then it also shows up in argocd. And it is deleted after 30min as desired: