fix(csi): Invalid mount point with volume detached #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantissahz
force-pushed
the
data-locality-pod-remount
branch
from
9a0cd17
to
b60b524
Compare
|
This pull request is now in conflicts. Could you fix it @mantissahz? 🙏 |
mantissahz
force-pushed
the
data-locality-pod-remount
branch
from
b60b524
to
4bde633
Compare
derekbit
reviewed
Jul 3, 2023
derekbit
reviewed
Jul 3, 2023
shuo-wu
previously approved these changes
Jul 3, 2023
mantissahz
force-pushed
the
data-locality-pod-remount
branch
from
bdf8c26
to
617532b
Compare
mantissahz
force-pushed
the
data-locality-pod-remount
branch
from
617532b
to
aae8aac
Compare
PhanLe1010
reviewed
Jul 3, 2023
PhanLe1010
reviewed
Jul 3, 2023
c3y1huang
requested changes
Jul 4, 2023
|
@mantissahz Please help check the remaining reviews from Chinya and Phan. |
mantissahz
force-pushed
the
data-locality-pod-remount
branch
from
aae8aac
to
bc5e98b
Compare
mantissahz
requested review from
PhanLe1010,
c3y1huang,
shuo-wu,
derekbit and
a team
innobead
reviewed
Jul 5, 2023
|
@mergify backport v1.5.x |
✅ Backports have been created
|
mantissahz
force-pushed
the
data-locality-pod-remount
branch
from
66ec4ab
to
06f4aa0
Compare
c3y1huang
previously approved these changes
Jul 5, 2023
derekbit
previously approved these changes
Jul 5, 2023
shuo-wu
reviewed
Jul 5, 2023
mantissahz
force-pushed
the
data-locality-pod-remount
branch
2 times, most recently
from
aebe700
to
96d6a89
Compare
Volume detached because only one replica failed and not remount the `globalmount`. We need to handle it at NodePublishVolume because os.ReadDir will be passed when it becomes a read-only file system after an unexpected volume detaching. Use an empty file to test the file system Ref: 4814, 5801 Signed-off-by: James Lu <james.lu@suse.com>
mantissahz
force-pushed
the
data-locality-pod-remount
branch
from
96d6a89
to
1dd2686
Compare
innobead
approved these changes
Jul 6, 2023
|
@mergify backport v1.5.x v1.4.x v1.3.x |
✅ Backports have been created
|
|
@mergify backport v1.4.x v1.3.x |
✅ Backports have been created
|
This was referenced Jul 6, 2023
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volume detached because only one replica failed and not remount the
globalmount. We need to handle it at NodePublishVolume because os.ReadDir will be passed when it becomes a read-only file system after an unexpected volume detaching.Ref: longhorn/longhorn#4814, longhorn/longhorn#5801
Test case test:
https://ci.longhorn.io/job/private/job/longhorn-tests-regression/4403/
https://ci.longhorn.io/job/private/job/longhorn-tests-regression/4425/