fix: remove the logic that sets datalocality to disable when v2 volume is created

[hookak]

Which issue(s) this PR fixes:

longhorn/longhorn#9280
longhorn/longhorn#9371

What this PR does / why we need it:

when a Longhorn engine v2 volume is created, the dataLocality field is always set to disable by the volume mutator in the webhook. To allow the use of different dataLocality settings for engine v2 volumes, this behavior should be removed.

Special notes for your reviewer:

Additional documentation or context

[derekbit]

@hookak
Nice catch! Thanks for your contribution.
We just implemented the online replica rebuilding feature in v1.7.0 and haven't verified the data locality feature. It is time to verify and support it in v1.8.0.

BTW, are you using v2 volumes in your environment?

[hookak]

Thanks, the data locality feature is important for our purposes.

We are looking for high-performance block storage, and the v2 volume is one of the options we're considering. We are testing its functionality and performance. The most important thing is whether we can operate this system reliably at a production level, but we haven't found a good example of that yet.

We are still not very familiar with Longhorn, especially the v2 volumes, so if there are any considerations we should be aware of, it would be great if you could let us know. @derekbit

[derekbit]

Hello @hookak

Need to remove https://github.com/longhorn/longhorn-manager/blob/master/webhook/resources/volume/validator.go#L269-L273 as well. After the removal, we can merge the PR. Thank you.

[hookak]

Hello, @derekbit

I have also removed the logic from the volume validator(https://github.com/longhorn/longhorn-manager/blob/master/webhook/resources/volume/validator.go#L269-L273)

[derekbit]

LGTM

[derekbit]

Merged. Thanks for your contribution @hookak. ;)

[innobead]

@hookak thanks for the contribution!