Add skeleton for test_engine_crash_during_live_upgrade #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscchien
force-pushed
the
test_engine_crash_during_live_upgrade
branch
from
a0fee41
to
31d8cfe
Compare
innobead
requested changes
Feb 19, 2024
| @pytest.mark.skip(reason="TODO") # NOQA | ||
| def test_engine_crash_during_live_upgrade(): | ||
| """ | ||
| 1. Create and attach a volume to a worklod, then write data into the |
There was a problem hiding this comment.
Suggested change
| 1. Create and attach a volume to a worklod, then write data into the | |
| 1. Create and attach a volume to a workload, then write data into the |
| 3. Send live upgrade request then immediately delete the related engine | ||
| manager pod/engine process (The new replicas are not in active in this | ||
| case). | ||
| 4. Verify the volume will detach then reattach automatically. |
There was a problem hiding this comment.
Suggested change
| 4. Verify the volume will detach then reattach automatically. | |
| 4. Verify the workload will be restarted and the volume will be reattached automatically. |
There was a problem hiding this comment.
Updated, thank you.
ref: 7859 Signed-off-by: Chris <chris.chien@suse.com>
chriscchien
force-pushed
the
test_engine_crash_during_live_upgrade
branch
from
31d8cfe
to
fc07d30
Compare
innobead
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add skeleton for test_engine_crash_during_live_upgrade
ref: 7859
Which issue(s) this PR fixes:
Issue longhorn/longhorn#7859
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context