Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton for test_engine_crash_during_live_upgrade #1712

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions manager/integration/tests/test_engine_upgrade.py
Original file line number Diff line number Diff line change
Expand Up @@ -1196,3 +1196,19 @@ def test_engine_live_upgrade_while_replica_concurrent_rebuild(client, # NOQA
for replica in volume2.replicas:
assert replica.image == engine_upgrade_image
assert replica.currentImage == engine_upgrade_image

@pytest.mark.skip(reason="TODO") # NOQA
def test_engine_crash_during_live_upgrade():
"""
1. Create and attach a volume to a workload, then write data into the
volume.
2. Deploy an extra engine image.
3. Send live upgrade request then immediately delete the related engine
manager pod/engine process (The new replicas are not in active in this
case).
4. Verify the workload will be restarted and the volume will be reattached
automatically.
5. Verify the upgrade is done during the reattachment.
(It actually becomes offline upgrade.)
6. Verify volume healthy and the data is correct.
"""