fix: check for timeout in wait_deployment_replica_ready and fail if so. #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still testing, so created PR as draft. |
|
RWX tests failed as hoped. The "broken" longhorn-share-manager image I am using is |
c3y1huang
reviewed
Mar 21, 2024
c3y1huang
approved these changes
Mar 25, 2024
Signed-off-by: James Munson <james.munson@suse.com>
c3y1huang
force-pushed
the
8183-check-deployment
branch
from
5c17e5c
to
4cbcf71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8183
What this PR does / why we need it:
Adds a check for timeout when waiting for deployment to create successfully.
Special notes for your reviewer:
Additional documentation or context